Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate rds_snapshot* modules and tests #1453

Conversation

alinabuzachis
Copy link
Contributor

@alinabuzachis alinabuzachis commented Sep 9, 2022

Depends-On: ansible-collections/amazon.aws#1012
Depends-On: #1481

Remove rds_snapshot* modules and tests
These modules have been migrated to amazon.aws
Update runtime.yml with redirects to that collection
Update ignore files

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@alinabuzachis: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibullbot
Copy link

@ansibullbot ansibullbot added module module needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage plugins plugin (any type) labels Sep 9, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 09s
✔️ build-ansible-collection SUCCESS in 5m 01s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 30s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 07s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 23s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 14s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 17s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 03s
✔️ ansible-test-splitter SUCCESS in 2m 41s
✔️ integration-community.aws-1 SUCCESS in 22m 09s
✔️ integration-community.aws-2 SUCCESS in 13m 36s
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@alinabuzachis alinabuzachis changed the title DNM Migrate rds_snapshot* modules and tests Migrate rds_snapshot* modules and tests Sep 13, 2022
@softwarefactory-project-zuul
Copy link
Contributor

This change depends on a change that failed to merge.

@tremble tremble force-pushed the promote_rds_snapshot branch from a905936 to 57383f9 Compare September 22, 2022 12:59
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Sep 22, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 02s
✔️ build-ansible-collection SUCCESS in 4m 55s
ansible-test-sanity-docker-devel FAILURE in 10m 05s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 12m 46s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 13m 31s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 41s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 48s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 02s
✔️ ansible-test-splitter SUCCESS in 2m 33s
✔️ integration-community.aws-1 SUCCESS in 25m 54s
✔️ integration-community.aws-2 SUCCESS in 17m 05s
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3fe38da into ansible-collections:main Sep 22, 2022
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…e rds instance (ansible-collections#1459)

rds_instance: add support for CACertificateIdentifier to create/update rds instance

SUMMARY

Fixes ansible-collections#1453
Allows setting up CACertificateIdentifier value while creating as well as updating rds instance.
Added supported for utilizing ca_certificate_idenifier to boto API call parameters.

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

rds_instance
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Jill R
Reviewed-by: Mike Graves <mgraves@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory) module module needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants