[PR #1398/4c67633c backport][stable-3] s3-lifecycle: fix remove rule with empty prefix #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3-lifecycle: fix remove rule with empty prefix SUMMARY In case of removing a lifecycle policy without a prefix, there will be no prefix key in the existing_rule filter Signed-off-by: Seena Fallah seenafallah@gmail.com ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_lifecycle Reviewed-by: Mark Chappell <None> (cherry picked from commit 4c67633)
tremble
approved these changes
Aug 9, 2022
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
… when cancelling request (ansible-collections#1402) ec2_spot_instance: add parameter to enable terminating spot instances when cancelling request SUMMARY This PR adds a new parameter terminate_instances (true | false) to enable terminating spot instances when cancelling request. Can be used only when state=absent. Fixes ansible-collections#1360 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_spot_instance ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1398 as merged into main (4c67633).
SUMMARY
In case of removing a lifecycle policy without a prefix, there will be no prefix key in the existing_rule filter
Signed-off-by: Seena Fallah seenafallah@gmail.com
ISSUE TYPE
COMPONENT NAME
s3_lifecycle