Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1322/d7f38627 backport][stable-4] route53_info: Add snake_cased return key,values to remaining methods #1327

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jul 7, 2022

This is a backport of PR #1322 as merged into main (d7f3862).

SUMMARY

Following up on #1236
Found more places where route53_info module does not return a snake_case output.

Added snake_case output to checker_ip_range_details , reusable_delegation_set_details, and get_health_check methods.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

route53_info

…1322)

route53_info: Add snake_cased return key,values to remaining methods

SUMMARY

Following up on #1236
Found more places where route53_info module does not return a snake_case output.
Added snake_case output to checker_ip_range_details , reusable_delegation_set_details, and get_health_check methods.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

route53_info

Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Mark Chappell <None>
(cherry picked from commit d7f3862)
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Jul 7, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 24s
✔️ build-ansible-collection SUCCESS in 5m 55s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 31s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 34s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 49s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 07s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 02s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 7m 16s
✔️ ansible-test-splitter SUCCESS in 2m 41s
✔️ integration-community.aws-1 SUCCESS in 7m 34s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 8, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 07s
✔️ build-ansible-collection SUCCESS in 4m 56s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 21s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 46s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 36s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 21s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 08s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 38s
✔️ ansible-test-splitter SUCCESS in 2m 33s
✔️ integration-community.aws-1 SUCCESS in 7m 31s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b5609d6 into stable-4 Jul 8, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-4/d7f38627fdb9e8309a6fcd7229610dc3f3da584e/pr-1322 branch July 8, 2022 05:20
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…1327)

[6.0.0] ec2_vpc_dhcp_options - drop new_options

SUMMARY
new_options was temporary, has been deprecated and should now be removed.
fixes: ansible-collections#1177
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_vpc_dhcp_options
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants