[PR #1309/29ab90eb backport][stable-4] Add support for check mode to SSM Parameter store #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for check mode to SSM Parameter store SUMMARY Adds support for check_mode Adds basic waiters for create/delete Fixes bug where module wasn't consistently idempotent ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME plugins/modules/aws_ssm_parameter_store.py ADDITIONAL INFORMATION Module was using a deprecated parameter when calling describe_parameters (Filters). This deprecated parameter appears to have some form of caching applied to it and would sometimes return old values. By switching to the ParameterFilters replacement things seem to be more consistent. Reviewed-by: Alina Buzachis <None> (cherry picked from commit 29ab90e)
tremble
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1309 as merged into main (29ab90e).
SUMMARY
ISSUE TYPE
COMPONENT NAME
plugins/modules/aws_ssm_parameter_store.py
ADDITIONAL INFORMATION
Module was using a deprecated parameter when calling
describe_parameters(Filters). This deprecated parameter appears to have some form of caching applied to it and would sometimes return old values. By switching to theParameterFiltersreplacement things seem to be more consistent.