[PR #640/932263d4 backport][stable-4] Add support for SQS RawMessageDelievery attribute in subscriptions - issue #193 #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or RawMessageDelievery (SQS) (#640) Add support for SQS RawMessageDelievery attribute in subscriptions - issue #193 SUMMARY Added support to configure RawMessageDelievery option when configuring sqs endpoints. It use boto3 set_subscription_attributes() to configure changes. It currently supports only this option, but should be easily extended in the future. Attributes are expected in the form as in the boto3 docs: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sns.html#SNS.Client.set_subscription_attributes Fixes #193 ISSUE TYPE Feature Pull Request COMPONENT NAME updates sns_topic.py to support new functionality example: - sns_topic: name: '{{ sns_topic_topic_name }}' display_name: My new topic name subscriptions: - endpoint: "{{ sqs_arn }}" protocol: sqs attributes: RawMessageDelivery: true Reviewed-by: Jill R <None> Reviewed-by: None <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> (cherry picked from commit 932263d)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
approved these changes
Jul 3, 2022
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…nsible-collections#1302) [6.0.0] s3_object - Remove support for creation/deletion of buckets. SUMMARY We previously deprecated support for creation/deletion of buckets using the s3_object module (s3_bucket performs the action much better). It is slated for removal in 6.0.0 Fixes ansible-collections#1112 ISSUE TYPE Feature Pull Request COMPONENT NAME s3_object ADDITIONAL INFORMATION Reviewed-by: GomathiselviS <None> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #640 as merged into main (932263d).
SUMMARY
Added support to configure
RawMessageDelieveryoption when configuring sqs endpoints.It use boto3
set_subscription_attributes()to configure changes.It currently supports only this option, but should be easily extended in the future.
Attributes are expected in the form as in the boto3 docs:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sns.html#SNS.Client.set_subscription_attributes
Fixes #193
ISSUE TYPE
COMPONENT NAME
updates sns_topic.py to support new functionality