[PR #1270/4435c8a6 backport][stable-1.5] Disable galaxy-importer docs tests #1280
Conversation
Disable galaxy-importer docs tests SUMMARY Because galaxy-importer tests the collections in a sterile environment it can't read the shared amazon.aws fragments. We're separately testing the docs more thoroughly using a github action, so we can disable the broken docs fragment testing via galaxy-importer ISSUE TYPE Feature Pull Request COMPONENT NAME tests/galaxy-importer.cfg ADDITIONAL INFORMATION (cherry picked from commit 4435c8a)
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 06s (non-voting) |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 53s (non-voting) |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 03s (non-voting) |
Sanity fix for changelog fragment SUMMARY Sanity fix for changelog fragment of ansible-collections#1275 The changelogs fragment is causing CI failure for sanity tests for other PRs such as ansible-collections#1253 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION
…nsible-collections#1253) route53_health_check: Fix "Name" tag key removal idempotentcy issue SUMMARY Depends-On: ansible-collections#1280 Fixes ansible-collections#1188 When using health_check_name as unique identifier (setting use_unique_names: True and providing a health_check_name) and health_check tags are set, Current logic for adding name to a health_check causes an issue when rerunning the create/update task. While ideally it should be idempotent, it removes the 'Name' tag (used for health_check_name) causing removal of health check name. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_health_check ADDITIONAL INFORMATION To test, run the following sample playbook task twice Expected output: Health check name should not disapper (i.e. 'Name' tag should not get removed on rerun) --- - hosts: localhost gather_facts: False tasks: - name: Create a health-check amazon.aws.route53_health_check: health_check_name: my-test-hc use_unique_names: true fqdn: my-test-xyz.com type: HTTPS resource_path: / request_interval: 30 failure_threshold: 3 tags: Service: my-service Owner: my-test-xyz Lifecycle: dev Reviewed-by: Mark Chappell <None> Reviewed-by: GomathiselviS <None> Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None>
This is a backport of PR #1270 as merged into main (4435c8a).
SUMMARY
Because galaxy-importer tests the collections in a sterile environment it can't read the shared amazon.aws fragments.
We're separately testing the docs more thoroughly using a github action, so we can disable the broken docs fragment testing via galaxy-importer
ISSUE TYPE
COMPONENT NAME
tests/galaxy-importer.cfg
ADDITIONAL INFORMATION