Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #1270/4435c8a6 backport][stable-4] Disable galaxy-importer docs tests #1279

Merged
merged 1 commit into from
Jun 29, 2022
Merged

[PR #1270/4435c8a6 backport][stable-4] Disable galaxy-importer docs tests #1279

merged 1 commit into from
Jun 29, 2022

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jun 29, 2022

This is a backport of PR #1270 as merged into main (4435c8a).

SUMMARY

Because galaxy-importer tests the collections in a sterile environment it can't read the shared amazon.aws fragments.

We're separately testing the docs more thoroughly using a github action, so we can disable the broken docs fragment testing via galaxy-importer

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

tests/galaxy-importer.cfg

ADDITIONAL INFORMATION

@tremble @patchback
Disable galaxy-importer docs tests (#1270)
4550561 
Disable galaxy-importer docs tests

SUMMARY
Because galaxy-importer tests the collections in a sterile environment it can't read the shared amazon.aws fragments.
We're separately testing the docs more thoroughly using a github action, so we can disable the broken docs fragment testing via galaxy-importer
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/galaxy-importer.cfg
ADDITIONAL INFORMATION

(cherry picked from commit 4435c8a)
@patchback patchback bot mentioned this pull request Jun 29, 2022
Merged
@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request needs_triage new_contributor Help guide this first time contributor tests tests labels Jun 29, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 5m 21s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 04s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 51s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 46s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 17s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 25s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 46s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 42s

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 29, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 11s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 53s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 02s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 39s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 27s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 30s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 39s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 7m 21s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit aba30a0 into stable-4 Jun 29, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-4/4435c8a64eada664d0d2cf742e8b2687058faf76/pr-1270 branch June 29, 2022 08:38
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@mdavis-xyz
lambda - Fix flaky integration tests which assume there are no other …
737ee75 
…functions in the account (ansible-collections#1279)

lambda - Fix flaky integration tests which assume there are no other functions in the account

SUMMARY
The integration tests for lambda assume that there are no other lambdas in the account.
So when we index into [0], that's not necessarily the lambda we just created.
Note that this fix doesn't work. One of the assertions is failing.
TASK [lambda : lambda_info | Assert successfull retrieval of all information 2] ***
fatal: [testhost]: FAILED! => {
    "assertion": "lambda_infos_all.function[lambda_function_name].versions is not defined",
    "changed": false,
    "evaluated_to": false,
    "msg": "Assertion failed"
}

That attribute is defined. It's a list of 2 versions. I don't know why.
I'm just creating this PR anyway, so someone else can pickup where I left off.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
lambda_info
ADDITIONAL INFORMATION
Fixes ansible-collections#1277

Reviewed-by: Mark Chappell <None>
Reviewed-by: Matthew Davis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) needs_triage new_contributor Help guide this first time contributor tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tremble @ansibullbot