Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1214/7a5ece48 backport][stable-2] wafv2_ip_set - fix bugs with changing description #1228

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jun 7, 2022

This is a backport of PR #1214 as merged into stable-3 (7a5ece4).

Manual backport of #1211

SUMMARY

Updating just the description didn't update the changed state

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

wafv2_ip_set

ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz

[stable-3] wafv2_ip_set - fix bugs with changing description

Manual backport of #1211
SUMMARY
Updating just the description didn't update the changed state
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
wafv2_ip_set
ADDITIONAL INFORMATION
Reviewed-by: Markus Bergholz

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 7a5ece4)
@tremble tremble changed the title [PR #1214/7a5ece48 backport][stable-2] [stable-3] wafv2_ip_set - fix bugs with changing description [PR #1214/7a5ece48 backport][stable-2] wafv2_ip_set - fix bugs with changing description Jun 7, 2022
@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Jun 7, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 09s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 46s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 19s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 09s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 36s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 57s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 28s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 22s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 45s
✔️ ansible-test-splitter SUCCESS in 2m 25s
✔️ integration-community.aws-1 SUCCESS in 5m 51s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Jun 8, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 5m 16s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 51s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 19s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 09s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 15m 17s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 57s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 38s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 14s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 14s
✔️ ansible-test-splitter SUCCESS in 2m 46s
✔️ integration-community.aws-1 SUCCESS in 5m 53s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 753f339 into stable-2 Jun 8, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-2/7a5ece48d95b009a5de9ee01b87bb77b8d17915f/pr-1214 branch June 8, 2022 04:39
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Disable broken RDS tests

SUMMARY
Tests are currently bust
ansible-collections#1228
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_cluster
ADDITIONAL INFORMATION
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
rds/tests: use aurora2 cluster by default

Aurora1 (provisioned and serverless) which comes with MySQL 5.6 will be soon deprecated by AWS.
See: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/Aurora.MySQL56.EOL.html
This commit also reverses change 8e7ac73.
Closes: ansible-collections#1228

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants