[PR #1216/01f32747 backport][stable-3] wafv2_web_acl - fix return values #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wafv2_web_acl - fix return values SUMMARY split integration tests from full wafv2 tests relax botocore requirement to bare minimum required return web acl info on update consistently return web acl info as described in documentation (create would nest it under "web_acl") fix "changed" value when description not specified ISSUE TYPE Bugfix Pull Request COMPONENT NAME wafv2_web_acl ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> (cherry picked from commit 01f3274)
markuman
approved these changes
Jun 8, 2022
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…e reuse (ansible-collections#1227) Move botocore version validation into module_utils.botocore for future reuse Depends-On: ansible-collections#1246 SUMMARY In preparation for ansible-collections#1225 move the SDK version validation pieces over into module_utils.botocore ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/botocore.py plugins/module_utils/core.py plugins/module_utils/exceptions.py plugins/module_utils/modules.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1216 as merged into main (01f3274).
SUMMARY
ISSUE TYPE
COMPONENT NAME
wafv2_web_acl
ADDITIONAL INFORMATION