Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_kms_info - remove deprecated keys_attr parameter #1172

Merged
merged 1 commit into from
May 30, 2022
Merged

aws_kms_info - remove deprecated keys_attr parameter #1172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/1172-aws_kms_info-keys_attr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
removed_features:
- aws_kms_info - the unused and deprecated ``keys_attr`` parameter has been removed (https://github.com/ansible-collections/amazon.aws/pull/1172).
15 changes: 0 additions & 15 deletions plugins/modules/aws_kms_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,6 @@
description: Whether to get full details (tags, grants etc.) of keys pending deletion.
default: False
type: bool
keys_attr:
description:
- Returning the C(keys) attribute conflicted with the builtin keys()
method on dictionaries and as such was deprecated.
- This parameter now does nothing, and after version C(4.0.0) this
parameter will be removed.
type: bool
version_added: 2.0.0
extends_documentation_fragment:
- amazon.aws.aws
- amazon.aws.ec2
Expand Down Expand Up @@ -496,7 +488,6 @@ def main():
key_id=dict(aliases=['key_arn']),
filters=dict(type='dict'),
pending_deletion=dict(type='bool', default=False),
keys_attr=dict(type='bool'),
)

module = AnsibleAWSModule(argument_spec=argument_spec,
Expand All @@ -515,12 +506,6 @@ def main():
filtered_keys = [key for key in all_keys if key_matches_filters(key, module.params['filters'])]
ret_params = dict(kms_keys=filtered_keys)

# We originally returned "keys"
if module.params.get('keys_attr') is not None:
module.deprecate("Returning results in the 'keys' attribute conflicts with the builtin keys() method on "
"dicts and as such was removed in version 3.0.0. Please use the kms_keys attribute. "
"This parameter is now ignored and will be removed in version 4.0.0.",
version='4.0.0', collection_name='community.aws')
module.exit_json(**ret_params)


Expand Down