Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs_service - fix validation for placementConstraints #1170

Merged

Conversation

novak-oleksandr
Copy link
Contributor

@novak-oleksandr novak-oleksandr commented May 26, 2022

SUMMARY

Fixes #1058

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ecs_service

@novak-oleksandr novak-oleksandr changed the title fix validation for ecs_service ecs_service - fix validation for placementConstraints May 26, 2022
@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels May 26, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 29s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 45s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 54s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 21s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 43s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 18s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 30s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 14s
✔️ ansible-test-splitter SUCCESS in 2m 33s
✔️ integration-community.aws-1 SUCCESS in 6m 37s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@novak-oleksandr novak-oleksandr marked this pull request as ready for review May 26, 2022 12:09
@markuman markuman mentioned this pull request May 26, 2022
10 tasks
@markuman markuman added backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch labels May 26, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 00s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 52s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 17s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 29s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 14m 54s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 30s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 49s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 17s
✔️ ansible-test-splitter SUCCESS in 2m 28s
✔️ integration-community.aws-1 SUCCESS in 7m 35s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

Co-authored-by: Markus Bergholz <git@osuv.de>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 16s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 41s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 07s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 06s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 14m 23s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 41s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 06s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 20s
✔️ ansible-test-splitter SUCCESS in 2m 27s
✔️ integration-community.aws-1 SUCCESS in 6m 04s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label May 30, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 5m 30s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 21s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 41s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 46s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 24s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 04s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 55s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 33s
✔️ ansible-test-splitter SUCCESS in 2m 51s
✔️ integration-community.aws-1 SUCCESS in 5m 31s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 688c7e8 into ansible-collections:main May 30, 2022
@patchback
Copy link

patchback bot commented May 30, 2022

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/688c7e89d9a6e7853b1aadab91288ed1c14c7cac/pr-1170

Backported as #1177

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 30, 2022
ecs_service - fix validation for `placementConstraints`

SUMMARY
Fixes #1058
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ecs_service

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Oleksandr Novak <novak.as@i.ua>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 688c7e8)
@patchback
Copy link

patchback bot commented May 30, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/688c7e89d9a6e7853b1aadab91288ed1c14c7cac/pr-1170

Backported as #1178

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 30, 2022
ecs_service - fix validation for `placementConstraints`

SUMMARY
Fixes #1058
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ecs_service

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Oleksandr Novak <novak.as@i.ua>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 688c7e8)
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 30, 2022
[PR #1170/688c7e89 backport][stable-3] ecs_service - fix validation for `placementConstraints`

This is a backport of PR #1170 as merged into main (688c7e8).
SUMMARY
Fixes #1058
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ecs_service

Reviewed-by: Markus Bergholz <git@osuv.de>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 30, 2022
[PR #1170/688c7e89 backport][stable-2] ecs_service - fix validation for `placementConstraints`

This is a backport of PR #1170 as merged into main (688c7e8).
SUMMARY
Fixes #1058
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ecs_service

Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Cleanup shared 'EC2' parameters

SUMMARY
As seen in both ansible-collections#1170 and ansible-collections#1458 the "EC2_" prefix for a number of fall-back environment variables results in confusion.  "EC2_" implies it's specific to the EC2 API, not all of AWS.

Deprecates the ec2_ parameter aliases
Deprecates the EC2_ environment variables
Deprecates the security_token/aws_security_token/access_token parameter aliases which were based on the original boto parameter names

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/botocore.py
plugins/module_utils/modules.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch bug This issue/PR relates to a bug community_review has_issue integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ecs_service cannot handle distinctInstance Placement Constraint
4 participants