Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_eip - remove wait_timeout #1159

Merged
merged 1 commit into from
May 25, 2022
Merged

ec2_eip - remove wait_timeout #1159

merged 1 commit into from
May 25, 2022

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 25, 2022

SUMMARY

Remove the wait_timeout option, it has always been ignored by the module

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_eip

ADDITIONAL INFORMATION

See also: ansible/ansible#64230

@tremble tremble force-pushed the deprecation/4.0.0/ec2_eip branch from 2f409d2 to 4f7af7d Compare May 25, 2022 11:38
@github-actions
Copy link

github-actions bot commented May 25, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

cc @jillr @markuman @RickMendes @s-hertel
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) small_patch Hopefully easy to review labels May 25, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

❌ ansible-galaxy-importer FAILURE in 3m 57s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 53s
❌ ansible-test-sanity-docker-devel RETRY_LIMIT in 6m 32s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 33s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 14m 36s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 48s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 01s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 47s
✔️ ansible-test-splitter SUCCESS in 2m 31s
✔️ integration-community.aws-1 SUCCESS in 11m 12s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble
Copy link
Contributor Author

tremble commented May 25, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

❌ ansible-galaxy-importer FAILURE in 4m 19s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 04s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 49s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 10s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 14m 54s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 28s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 21s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 22s
✔️ ansible-test-splitter SUCCESS in 2m 39s
✔️ integration-community.aws-1 SUCCESS in 11m 08s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble requested review from alinabuzachis and markuman May 25, 2022 15:10
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 25, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

❌ ansible-galaxy-importer FAILURE in 4m 29s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 51s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 06s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 24s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 13m 11s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 12m 06s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 34s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 29s
✔️ ansible-test-splitter SUCCESS in 2m 38s
✔️ integration-community.aws-1 SUCCESS in 13m 18s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 9460ca1 into ansible-collections:main May 25, 2022
@renovate renovate bot mentioned this pull request Jun 24, 2022
Merged
1 task
@tremble tremble deleted the deprecation/4.0.0/ec2_eip branch July 7, 2022 19:27
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble @goneri
ec2_eip - remove wait_timeout (ansible-collections#1159)
ddf6313 
ec2_eip - remove wait_timeout

SUMMARY
Remove the wait_timeout option, it has always been ignored by the module
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_eip
ADDITIONAL INFORMATION
See also: ansible/ansible#64230

Reviewed-by: Markus Bergholz <git@osuv.de>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@9460ca1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuman markuman markuman approved these changes

@alinabuzachis alinabuzachis Awaiting requested review from alinabuzachis

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @ansibullbot @markuman