Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #840/c67c8907 backport][stable-3] Support changing of launch type #1008

Merged
merged 1 commit into from
Mar 19, 2022
Merged

[PR #840/c67c8907 backport][stable-3] Support changing of launch type #1008

merged 1 commit into from
Mar 19, 2022

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Mar 18, 2022

This is a backport of PR #840 as merged into main (c67c890).

SUMMARY

When changing the launch_type parameter for an ecs_taskdefition there was no change reported by the module. This adds a check to see if launch_type in the ecs_taskdefinition has changed. If there is a change detected the module reports back there is not a matching task definition and creates a new one.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ecs_taskdefinition

@mjmayer @patchback
Support changing of launch type (#840)
bf38d34 
Support changing of launch type

SUMMARY
When changing the launch_type parameter for an ecs_taskdefition there was no change reported by the module. This adds a check to see if launch_type in the ecs_taskdefinition has changed. If there is a change detected the module reports back there is not a matching task definition and creates a new one.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ecs_taskdefinition

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Michael Mayer <mjmayer@gmail.com>
Reviewed-by: Markus Bergholz <git@osuv.de>
(cherry picked from commit c67c890)
@patchback patchback bot mentioned this pull request Mar 18, 2022
Merged
@ansibullbot
Copy link

cc @Java1Guy @alinabuzachis @jillr @markuman @s-hertel @tremble
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Mar 18, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Mar 19, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 00a26e9 into stable-3 Mar 19, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-3/c67c890726a512b5bfadf0cfa97f1534ce470711/pr-840 branch March 19, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansibullbot @markuman @mjmayer