-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create PAY_PER_REQUEST dynamodb table #609
Comments
Files identified in the description:
If these files are inaccurate, please update the |
I would be very interested in this addition as well. I am totally new (with ansible in general), but i would be willing to give it a shot to try to contribute. |
@tremble many thanks for the feedback. I'll watch the other PR then. Since i would be a first time contributer and new to the topic, do you think, i would be able to tackle this? |
Some of the dynamodb code isn't exactly the most "beginner friendly" (avoid looking too deep into the index/attributes pieces). However, hopefully with the way it's written in 726 adding support to manage "BillingMode" would be a relatively simple change. |
Hey 👋🏻 So I do actually have a branch lined up now with the |
DynamoDB billing mode support SUMMARY Current the dynamodb_table module only supports provisioned table creations, this adds support for defining a billing_mode to create either pay_per_request or provisioned tables. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/dynamodb.html#DynamoDB.Client.create_table This change does also allow for changing the billing_mode on existing tables. fixes: #609 ISSUE TYPE Feature Pull Request COMPONENT NAME dynamodb_table ADDITIONAL INFORMATION Example of creating a DynamoDB table with pay_per_request: - name: Create a pay-per-request table community.aws.dynamodb_table: name: my-table region: eu-west-1 hash_key_name: id hash_key_type: STRING billing_mode: PAY_PER_REQUEST Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None>
SUMMARY
Dynamodb tables can either have a fixed capacity, or be serverless (autoscaling).
The
dynamodb_table
Ansible module can only create a fixed capacity table. I want to use it to create an autoscaling table.ISSUE TYPE
COMPONENT NAME
dynamodb_table
ADDITIONAL INFORMATION
Interface:
The
read_capacity
andwrite_capacity
fields default to 1.I feel like semantically it would be nice to default to PAY_PER_REQUEST if both read and write capacity were omitted. Although that might be considered a backwards incompatible change.
Alternatively, what if the capacity fields accept a string like "PAY_PER_REQUEST"? Or we add an additional field?
or:
Implementation:
I looked at the code. It doesn't make sense to me.
Table.create()
is not a documented method.The text was updated successfully, but these errors were encountered: