Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_scaling_policy - Add support for TargetTrackingScaling policies #544

Closed
anjo-swe opened this issue Apr 14, 2021 · 7 comments · Fixed by #771
Closed

ec2_scaling_policy - Add support for TargetTrackingScaling policies #544

anjo-swe opened this issue Apr 14, 2021 · 7 comments · Fixed by #771
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@anjo-swe
Copy link
Contributor

SUMMARY

Allow creation of TargetTrackingScaling policies using ec2_scaling_policy module

References
ISSUE TYPE
  • Feature Idea
COMPONENT NAME

ec2_scaling_policy

ADDITIONAL INFORMATION

Feature would be used similar to how you can currently create SimpleScaling (default) & StepScaling policies. The module would need a similar if-statement that was added for StepScaling - https://github.com/ansible-collections/community.aws/blob/main/plugins/modules/ec2_scaling_policy.py#L275-L290

- name: Target tracking scaling policy
  community.aws.ec2_scaling_policy:
    state: present
    region: US-XXX
    name: "target-tracking-scaling-policy"
    policy_type: TargetTrackingScaling
    target_tracking_configuration:
      target_value: 40.0
      predefined_metric_specification:
        predefined_metric_type: ASGAverageCPUUtilization
    asg_name: "application-asg"
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

cc @Zeekin @jillr @s-hertel @tremble @wimnat @Zeekin
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module needs_triage plugins plugin (any type) labels Apr 14, 2021
@alinabuzachis
Copy link
Contributor

Hi @anjo-swe, thank you for this feature idea. Would you be interested in creating a PR for this feature?

@goneri goneri added waiting_on_contributor Needs help. Feel free to engage to get things unblocked and removed needs_triage labels Jun 15, 2021
@falcon78921
Copy link
Contributor

@alinabuzachis If no one is working on this issue, I would love to! :)

@ansibullbot
Copy link

cc @markuman
click here for bot help

@tremble
Copy link
Contributor

tremble commented Oct 18, 2021

@falcon78921

Thanks for the offer, if you can't find an existing pull request, feel free to start working on it.

@falcon78921 falcon78921 mentioned this issue Oct 19, 2021
Merged
@lyz-code
Copy link

Thanks for the implementation @falcon78921

alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue May 25, 2022
@tremble
ec2_vpc_endpoint - Add vpc_endpint_subnets and vpc_endpoint_security_…
f8a830b 
…groups parameters. (ansible-collections#544)

ec2_vpc_endpoint - Add vpc_endpint_subnets and vpc_endpoint_security_groups parameters.

SUMMARY
Add support for setting the subnet and security group used by the Endpoint
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_vpc_endpoint
ADDITIONAL INFORMATION
Originally submitted as ansible-collections#589

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
softwarefactory-project-zuul bot pushed a commit that referenced this issue Jul 4, 2022
@falcon78921
add TargetTrackingScaling as a scaling policy option (#771)
4be1e70 
add `TargetTrackingScaling` as a scaling policy option

SUMMARY

Add TargetTrackingScaling as an EC2 scaling option.
Fixes: #544

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_scaling_policy.py

Reviewed-by: Jill R <None>
Reviewed-by: James McClune <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
patchback bot pushed a commit that referenced this issue Jul 4, 2022
@falcon78921 @patchback
add TargetTrackingScaling as a scaling policy option (#771)
e50a8d4 
add `TargetTrackingScaling` as a scaling policy option

SUMMARY

Add TargetTrackingScaling as an EC2 scaling option.
Fixes: #544

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ec2_scaling_policy.py

Reviewed-by: Jill R <None>
Reviewed-by: James McClune <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
(cherry picked from commit 4be1e70)
@patchback patchback bot mentioned this issue Jul 4, 2022
Merged
tremble pushed a commit that referenced this issue Jul 4, 2022
@falcon78921 @tremble
add TargetTrackingScaling as a scaling policy option (#771)
590c15f 
add `TargetTrackingScaling` as a scaling policy option

SUMMARY

Add TargetTrackingScaling as an EC2 scaling option.
Fixes: #544

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ec2_scaling_policy.py

Reviewed-by: Jill R <None>
Reviewed-by: James McClune <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
(cherry picked from commit 4be1e70)
softwarefactory-project-zuul bot pushed a commit that referenced this issue Jul 4, 2022
@patchback
add TargetTrackingScaling as a scaling policy option (#771) (#1306)
733a1eb 
[PR #771/4be1e701 backport][stable-4] add `TargetTrackingScaling` as a scaling policy option

This is a backport of PR #771 as merged into main (4be1e70).
SUMMARY

Add TargetTrackingScaling as an EC2 scaling option.
Fixes: #544

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_scaling_policy.py

Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add TargetTrackingScaling as a scaling policy option falcon78921/community.aws
7 participants
@goneri @tremble @anjo-swe @lyz-code @falcon78921 @alinabuzachis @ansibullbot