Skip to content

Commit

Permalink
sanity and linter fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
mandar242 committed Mar 6, 2025
1 parent c24801a commit fde7a6c
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
5 changes: 3 additions & 2 deletions plugins/connection/aws_ssm.py
Original file line number Diff line number Diff line change
Expand Up @@ -521,10 +521,11 @@ def _init_clients(self) -> None:
# Initialize S3 client
s3_endpoint_url, s3_region_name = self.s3_manager.get_bucket_endpoint()
self._vvvv(f"SETUP BOTO3 CLIENTS: S3 {s3_endpoint_url}")
self.s3_manager.initialize_client(region_name=s3_region_name, endpoint_url=s3_endpoint_url, profile_name=profile_name)
self.s3_manager.initialize_client(
region_name=s3_region_name, endpoint_url=s3_endpoint_url, profile_name=profile_name
)
self._s3_client = self.s3_manager._s3_client


# Initialize SSM client
self._initialize_ssm_client(region_name, profile_name)

Expand Down
12 changes: 8 additions & 4 deletions tests/unit/plugins/connection/aws_ssm/test_aws_ssm.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,14 @@


class TestConnectionBaseClass:
@patch("ansible_collections.community.aws.plugins.module_utils.s3clientmanager.S3ClientManager.get_bucket_endpoint",
return_value=("fake-s3-endpoint", "fake-region"))
@patch("ansible_collections.community.aws.plugins.module_utils.s3clientmanager.S3ClientManager.get_s3_client",
return_value=MagicMock())
@patch(
"ansible_collections.community.aws.plugins.module_utils.s3clientmanager.S3ClientManager.get_bucket_endpoint",
return_value=("fake-s3-endpoint", "fake-region"),
)
@patch(
"ansible_collections.community.aws.plugins.module_utils.s3clientmanager.S3ClientManager.get_s3_client",
return_value=MagicMock(),
)
def test_init_clients(self, mock_get_s3_client, mock_get_bucket_endpoint):
pc = PlayContext()
new_stdin = StringIO()
Expand Down

0 comments on commit fde7a6c

Please sign in to comment.