Skip to content

Commit

Permalink
[Plugin elasticache_info] includes the description of each replicatio…
Browse files Browse the repository at this point in the history
…n group (#646) (#1292)

[PR #646/d7e36178 backport][stable-4] [Plugin elasticache_info] includes the description of each replication group

This is a backport of PR #646 as merged into main (d7e3617).
SUMMARY
This pull request add the description of the corresponding Elasticache replication group into each described cache cluster.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elasticache_info
ADDITIONAL INFORMATION
Actually the only way to describe Elasticache replication groups with Ansible is to use the dynamic inventory.
However, exposing the informations about each replication group could be useful in other contexts.
In my case, I am generating a few .env files and I need to include some Elasticache replication group primary endpoint and reader endpoint.
Since the elasticache_info plugin already exist and already retrieves the appropriate replication_group_id, I believe that this plugin should also retrieve the replication group description when it exists.
OTHER REMARKS CONCERNING THIS PULL REQUEST
Each provided description is copy/pasted from the official boto3 documentation which is distributed under an Apache 2.0 licence. I did it for consistency reason between and also because I am not a native speaker.
Also the provided description is incomplete : I only documented the fields that I was able to retrieve from my current AWS clusters.
Boto3 documentation of the "describe_replication_groups" function : https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elasticache.html#ElastiCache.Client.describe_replication_groups
Moreover this pull request might violates the "integration tests" rule : I didn't find any integration test for the elasticache_info plugin and I don't know why no integration test have been made.

Reviewed-by: Mark Chappell <None>
  • Loading branch information
patchback[bot] authored Jul 1, 2022
1 parent 52d9b70 commit b18c203
Show file tree
Hide file tree
Showing 5 changed files with 329 additions and 50 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- elasticache_info - added ``replication_group`` to the returned information for an elasticache cluster (https://github.com/ansible-collections/community.aws/pull/646).
Loading

0 comments on commit b18c203

Please sign in to comment.