Initialize sys_path_lock after the double fork() #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change address a problem on MacOS. If we create the asyncio lock before we do the double forks, it actually initialize the asyncio context in the father process. And later we get an "Bad file descriptor" when we try to start the asyncio endless loop in the child process. See: https://python-tornado.narkive.com/a9lCRPxp/errno-9-bad-file-descriptor#post2 Closes: ansible-collections#13
66d0a1b to
10bcecc
Compare
goneri
added a commit
to goneri/cloud.common
that referenced
this pull request
Oct 20, 2020
ansible-zuul bot
pushed a commit
that referenced
this pull request
Oct 20, 2020
add a changelog entry for fix #16 Reviewed-by: https://github.com/apps/ansible-zuul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change address a problem on MacOS.
If we create the asyncio lock before we do the double forks, it
actually initialize the asyncio context in the father process. And later
we get an "Bad file descriptor" when we try to start the asyncio endless
loop in the child process.
See: https://python-tornado.narkive.com/a9lCRPxp/errno-9-bad-file-descriptor#post2
Closes: #13