Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure.mgmt.web #849

Merged
merged 10 commits into from
Jun 20, 2022

Conversation

l3ender
Copy link
Contributor

@l3ender l3ender commented May 12, 2022

SUMMARY

This PR updates azure.mgmt.web to the latest version. The version was quite old, so this change will help bring the latest SDK updates into the collection and avoid conflicts with other tools like azure-cli.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_appserviceplan
azure_rm_appserviceplan_info
azure_rm_functionapp
azure_rm_functionapp_info
azure_rm_webapp
azure_rm_webapp_info
azure_rm_webappslot

ADDITIONAL INFORMATION

The following were removed from azure_rm_webapp input parameters as they are not used and I cannot find any reference to them in the SDK (old or new version). For backwards compatibility, I have kept them remaining as output parameters.

  • dns_registration
  • skip_custom_domain_verification
  • ttl_in_seconds

I have run sanity and integration tests to verify functionality:

ansible-test sanity azure_rm_appserviceplan --color --junit -v
ansible-test sanity azure_rm_functionapp --color --junit -v
ansible-test sanity azure_rm_webapp --color --junit -v
ansible-test sanity azure_rm_webappslot --color --junit -v

ansible-test integration azure_rm_appserviceplan --allow-destructive -v --allow-unstable
ansible-test integration azure_rm_functionapp --allow-destructive -v
ansible-test integration azure_rm_webapp --allow-destructive -v

Important!!! The azure_rm_webapp integration tests require RESOURCE_GROUP and RESOURCE_GROUP_SECONDARY to be in the same region.

@l3ender l3ender marked this pull request as ready for review May 14, 2022 22:45
@l3ender
Copy link
Contributor Author

l3ender commented May 14, 2022

@Fred-sun @xuzhang3 This PR is ready. Please take a look and let me know if I can enhance anything. Thank you!

@xuzhang3 xuzhang3 added the enhancement New feature or request label May 17, 2022
@Fred-sun
Copy link
Collaborator

@l3ender Why delete parameters "dns_registration" and "skip_custom_domain_verification" for "azure_rm_webapp "?

@Fred-sun Fred-sun added medium_priority Medium priority work in In trying to solve, or in working with contributors labels May 24, 2022
@l3ender
Copy link
Contributor Author

l3ender commented May 24, 2022

@Fred-sun I couldn't find any reference to the parameters in the SDK (old or new version) and they were not used anywhere, so I thought it best to just remove them. Thanks!

@Fred-sun
Copy link
Collaborator

@Fred-sun I couldn't find any reference to the parameters in the SDK (old or new version) and they were not used anywhere, so I thought it best to just remove them. Thanks!

Yes, these two parameters will not be available in the version after the release of 2016-08-01. We will reply after discussion. Thank you very much!

@Fred-sun
Copy link
Collaborator

@l3ender delete

@l3ender
Copy link
Contributor Author

l3ender commented May 25, 2022

@Fred-sun updated!

@Fred-sun
Copy link
Collaborator

@l3ender Function name not found in module "azure_rm_webappvnetconnection.py"!

@l3ender
Copy link
Contributor Author

l3ender commented May 25, 2022

@l3ender Function name not found in module "azure_rm_webappvnetconnection.py"!

Updated in 94f83e9. Thank you!

@Fred-sun
Copy link
Collaborator

Fred-sun commented May 26, 2022

@l3ender To create the "web app service" has a set of default ipSecurityRestrictions and scmIpSecurityRestrictions, So the test cases' "tests/integration/the targets/azure_rm_webappaccessrestriction/tasks/main yml" changes to do synchronization. Thank you very much!

The default information is:
                "ipSecurityRestrictions": [
                    {
                        "ipAddress": "Any",
                        "action": "Allow",
                        "priority": 1,
                        "name": "Allow all",
                        "description": "Allow all access"
                    }
                ],
                "scmIpSecurityRestrictions": [
                    {
                        "ipAddress": "Any",
                        "action": "Allow",
                        "priority": 1,
                        "name": "Allow all",
                        "description": "Allow all access"
                    }
                ],
                "scmIpSecurityRestrictionsUseMain": false,

@l3ender
Copy link
Contributor Author

l3ender commented Jun 3, 2022

@Fred-sun - sorry for the delay. I have resolved in 7765214, which filters out the Azure default rules (which are not editable by user).

Thank you!

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Jun 6, 2022
@Fred-sun
Copy link
Collaborator

Fred-sun commented Jun 6, 2022

ready_for_review

@xuzhang3
Copy link
Collaborator

xuzhang3 commented Jun 20, 2022

@l3ender LGTM

@xuzhang3 xuzhang3 merged commit f2da741 into ansible-collections:dev Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants