-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update azure.mgmt.web #849
Update azure.mgmt.web #849
Conversation
@l3ender Why delete parameters "dns_registration" and "skip_custom_domain_verification" for "azure_rm_webapp "? |
@Fred-sun I couldn't find any reference to the parameters in the SDK (old or new version) and they were not used anywhere, so I thought it best to just remove them. Thanks! |
Yes, these two parameters will not be available in the version after the release of 2016-08-01. We will reply after discussion. Thank you very much! |
@l3ender delete
|
@Fred-sun updated! |
@l3ender Function name not found in module "azure_rm_webappvnetconnection.py"! |
@l3ender To create the "web app service" has a set of default ipSecurityRestrictions and scmIpSecurityRestrictions, So the test cases' "tests/integration/the targets/azure_rm_webappaccessrestriction/tasks/main yml" changes to do synchronization. Thank you very much!
|
ready_for_review |
@l3ender LGTM |
SUMMARY
This PR updates
azure.mgmt.web
to the latest version. The version was quite old, so this change will help bring the latest SDK updates into the collection and avoid conflicts with other tools like azure-cli.ISSUE TYPE
COMPONENT NAME
azure_rm_appserviceplan
azure_rm_appserviceplan_info
azure_rm_functionapp
azure_rm_functionapp_info
azure_rm_webapp
azure_rm_webapp_info
azure_rm_webappslot
ADDITIONAL INFORMATION
The following were removed from
azure_rm_webapp
input parameters as they are not used and I cannot find any reference to them in the SDK (old or new version). For backwards compatibility, I have kept them remaining as output parameters.I have run sanity and integration tests to verify functionality:
Important!!! The azure_rm_webapp integration tests require
RESOURCE_GROUP
andRESOURCE_GROUP_SECONDARY
to be in the same region.