#738 add mandatory field when updating IPAddress #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sku seems to be mandatory in Azure API
|
@verhyppo Thank you for your contribution and we will review and move forward with the merger as soon as possible. Thank you very much! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixed #738
ISSUE TYPE
COMPONENT NAME
azure_rm_publicipaddress
ADDITIONAL INFORMATION
Sku is mandatory in azure API and this is why we need to have it while requesting changes otherwhise, the services complain you are trying to change the sku defaulting to Basic.
see #738 to have a better understanding of what's happening.