Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix manageddisk unmount documentation #649

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Fix manageddisk unmount documentation #649

merged 1 commit into from
Oct 19, 2021

Conversation

nbr23
Copy link
Contributor

@nbr23 nbr23 commented Oct 12, 2021

SUMMARY

Fix manageddisk unmount documentation.
To unmount a disk, managed_by needs to be set to ''. Simply not setting managed_by does not accomplish the desired effect of unmounting.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

azure_rm_manageddisk

@Fred-sun Fred-sun added medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged labels Oct 12, 2021
@xuzhang3
Copy link
Collaborator

LGTM

@xuzhang3 xuzhang3 merged commit 13c41b0 into ansible-collections:dev Oct 19, 2021
@nbr23 nbr23 deleted the manageddisk-umount-doc branch October 19, 2021 13:16
nbr23 added a commit to nbr23/azure that referenced this pull request Oct 26, 2021
@nbr23
Fix manageddisk unmount documentation (ansible-collections#649)
1047661
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbr23 @xuzhang3 @Fred-sun