Add support for Azure AD with User Password #584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I struggled with this for the better part of a half of a day, hopefully this can be pulled in to save someone the trouble I went through. Issue is that when using a service principal azure AD operations will work as the auth flow is configured for that eventuality. When using username password, it is NOT. This fixes that issue. I would guess that a test should be written for this case so that it is dealt with in the future, but I am probably not the person to add a test to your setup.
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
|
Repeate #537, It has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I struggled with this for the better part of a half of a day, hopefully this can be pulled in to save someone the trouble I went through.
Issue is that when using a service principal azure AD operations will work as the auth flow is configured for that eventuality. When using username password, it is NOT. This fixes that issue.
I would guess that a test should be written for this case so that it is dealt with in the future, but I am probably not the person to add a test to your setup.
ISSUE TYPE
COMPONENT NAME
This is part of the module utils common auth.
ADDITIONAL INFORMATION
The, fairly unhelpful error that showed up BEFORE the change:
After the patch things work as expected with username password auth.