-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New module: azure_rm_privatednszonelink #495
New module: azure_rm_privatednszonelink #495
Conversation
@techcon65 Please help to change the module name to ”azure_rm_privatednszonelink*“, which is consistent with other modules, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@techcon65 Thanks for your contribution!Please remove "plugins/modules/azure_rm_privatednszone_vnetlink.py validate-modules:required_if-requirements-unknown
plugins/modules/azure_rm_privatednszone_vnetlink.py validate-modules:required_if-unknown-key" in ignore*.txt and add follow parameter to your module!
In addition, please share the result of you execute "tests/integration/targets/azure_rm_notificationhub/tasks/main.yml " Thank you!
log_path:
description:
- parent argument.
type: str
log_mode:
description:
- parent argument.
type: str
tests/integration/targets/azure_rm_privatednszone_vnetlink/aliases
Outdated
Show resolved
Hide resolved
…ases Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
…to 318-virtualNetworkLinks
…5/azure into 318-virtualNetworkLinks
@Fred-sun updated the file names as suggested, Thank you very much! |
@Fred-sun Incorporated all the changes.
|
@Fred-sun Tested the integration test file with ansible-test, sharing the results for reference. was trying with ansible-playbook earlier. Thank you!
|
…to 318-virtualNetworkLinks
Hi @Fred-sun Can you please review this PR? Thanks a lot!! |
@techcon65 I am working on it! Thank you very much! |
* class are worngly named. fixed. * fixing sanity errors.
…to 318-virtualNetworkLinks
2281f46
to
8dfc8ed
Compare
…to 318-virtualNetworkLinks
…to 318-virtualNetworkLinks
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
tests/integration/targets/azure_rm_privatednszonelink/tasks/main.yml
Outdated
Show resolved
Hide resolved
…in.yml Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
SUMMARY
This module supports following operations :
Fixes #318
ISSUE TYPE
COMPONENT NAME
azure_rm_privatednszonelink
azure_rm_privatednszonelink_info
ADDITIONAL INFORMATION
https://docs.microsoft.com/en-us/rest/api/dns/privatedns/virtualnetworklinks