Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add managed identity support to "azure_rm_cosmosdbaccount" #1645

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

nirarg
Copy link
Collaborator

@nirarg nirarg commented Jul 23, 2024

SUMMARY

This change add idendtity and default_identity attributes to azure_rm_cosmosdbaccount.
In order to support "Update" operation properly, changed it to use "begin_update" as part of the update operation (instead of "begin_create_or_update")

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_cosmosdbaccount

@nirarg
Copy link
Collaborator Author

nirarg commented Jul 23, 2024

CI verification was started here:
https://dev.azure.com/azclitools/public/_build/results?buildId=174985&view=results

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged new_feature New feature requirments labels Jul 23, 2024
@nirarg
Copy link
Collaborator Author

nirarg commented Aug 28, 2024

Hi @Fred-sun @xuzhang3
Is there any update regarding this PR review?
Is there anything else required to complete here before merge?

@xuzhang3 xuzhang3 merged commit a31c635 into ansible-collections:dev Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new_feature New feature requirments ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants