Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure_rm_openshiftmanagedcluster.py #1629

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Update azure_rm_openshiftmanagedcluster.py #1629

merged 1 commit into from
Jul 23, 2024

Conversation

p3ck
Copy link
Collaborator

@p3ck p3ck commented Jul 11, 2024

SUMMARY

Looks like we need to check if the attribute is set before trying to use it.

Fixes #1628

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_openshiftmanagedcluster.py

Looks like we need to check if the attribute is set before trying to use it.

Fixes #1628
@p3ck p3ck requested a review from Fred-sun July 11, 2024 21:08
Copy link
Contributor

@paulczar paulczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! This should fix my issue.

@paulczar
Copy link
Contributor

I was about to PR a very similar fix! thanks so much for beating me to it.

@p3ck
Copy link
Collaborator Author

p3ck commented Jul 12, 2024

If you can test the PR we would be very grateful. Thanks!

@paulczar
Copy link
Contributor

tested and yes I can confirm this fixes it

@p3ck p3ck added bug Something isn't working ready_for_review The PR has been modified and can be reviewed and merged labels Jul 12, 2024
@Fred-sun Fred-sun added medium_priority Medium priority work in In trying to solve, or in working with contributors ready_for_review The PR has been modified and can be reviewed and merged and removed bug Something isn't working ready_for_review The PR has been modified and can be reviewed and merged work in In trying to solve, or in working with contributors labels Jul 15, 2024
@xuzhang3 xuzhang3 merged commit 4cba904 into dev Jul 23, 2024
Justwmz pushed a commit to Justwmz/azure that referenced this pull request Nov 4, 2024
Looks like we need to check if the attribute is set before trying to use it.

Fixes ansible-collections#1628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[azure_rm_openshiftmanagedcluster] properties.clusterProfile.resourceGroupId set to null, produces error
4 participants