Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix azure_rm_aks_info.py to list all manged cluster bug #1229

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Fix azure_rm_aks_info.py to list all manged cluster bug #1229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions plugins/modules/azure_rm_aks_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,12 @@ def exec_module(self, **kwargs):
for key in self.module_args:
setattr(self, key, kwargs[key])

self.results['aks'] = (
self.get_item() if self.name
else self.list_items()
)
if self.name is not None and self.resource_group is not None:
self.results['aks'] = self.get_item()
elif self.resource_group is not None:
self.results['aks'] = self.list_by_resourcegroup()
else:
self.results['aks'] = self.list_items()

return self.results

Expand All @@ -145,13 +147,33 @@ def get_item(self):

return result

def list_by_resourcegroup(self):
"""Get all Azure Kubernetes Services"""

self.log('List all Azure Kubernetes Services under resource group')

try:
response = self.managedcluster_client.managed_clusters.list_by_resource_group(self.resource_group)
except Exception as exc:
self.fail('Failed to list all items - {0}'.format(str(exc)))

results = []
for item in response:
if self.has_tags(item.tags, self.tags):
item_dict = self.serialize_obj(item, AZURE_OBJECT_CLASS)
if self.show_kubeconfig:
item_dict['kube_config'] = self.get_aks_kubeconfig(self.resource_group, item.name)
results.append(item_dict)

return results

def list_items(self):
"""Get all Azure Kubernetes Services"""

self.log('List all Azure Kubernetes Services')

try:
response = self.managedcluster_client.managed_clusters.list(self.resource_group)
response = self.managedcluster_client.managed_clusters.list()
except Exception as exc:
self.fail('Failed to list all items - {0}'.format(str(exc)))

Expand All @@ -160,7 +182,7 @@ def list_items(self):
if self.has_tags(item.tags, self.tags):
item_dict = self.serialize_obj(item, AZURE_OBJECT_CLASS)
if self.show_kubeconfig:
item_dict['kube_config'] = self.get_aks_kubeconfig(self.resource_group, item.name)
item_dict['kube_config'] = self.get_aks_kubeconfig(item.resource_group, item.name)
results.append(item_dict)

return results
Expand Down