Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation of azure_rm_virtualnetwork to reflect that the dns_servers limit on length is no longer 2. #1082

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Update documentation of azure_rm_virtualnetwork to reflect that the dns_servers limit on length is no longer 2. #1082

merged 3 commits into from
Mar 31, 2023

Conversation

kmj251
Copy link
Contributor

@kmj251 kmj251 commented Feb 16, 2023 •
edited
Loading

SUMMARY

Updated the documentation for the azure_rm_virtualnetwork module to reflect that the dns_servers variable doesn't have a limit on the length of the list.

Fixes #1081

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
The documentation says that the dns_servers list variable has a maximum length of 2. There is no limit to the number of DNS servers, so the documentation is incorrect.

@kmj251
Update documentation of azure_rm_virtualnetwork to reflect that the…
f30b476 
… `dns_servers` limit on length is no longer 2.
@kmj251 kmj251 changed the title Update documentation of azure_rm_virtualnetwork to reflect that the dns_servers limit on length is no longer 2. Update documentation of azure_rm_virtualnetwork to reflect that the dns_servers limit on length is no longer 2. Resolves #1081 Feb 16, 2023
@kmj251 kmj251 changed the title Update documentation of azure_rm_virtualnetwork to reflect that the dns_servers limit on length is no longer 2. Resolves #1081 Update documentation of azure_rm_virtualnetwork to reflect that the dns_servers limit on length is no longer 2. Feb 16, 2023
Fred-sun
Fred-sun reviewed Feb 21, 2023
View reviewed changes
@Fred-sun Fred-sun added documentation-pr Improvements or additions to documentation medium_priority Medium priority work in In trying to solve, or in working with contributors labels Feb 21, 2023
@kmj251
Update galaxy.yml
30efee8 
Putting this back. Updated for local testing and forgot to put it back to 1.14.0
@kmj251
Copy link
Contributor Author

kmj251 commented Feb 21, 2023

@Fred-sun Sorry about that. I changed it for local testing and forgot to put it back. Thanks for catching that!

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Feb 21, 2023
@xuzhang3 xuzhang3 merged commit 3cf1358 into ansible-collections:dev Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fred-sun Fred-sun Fred-sun left review comments

@xuzhang3 xuzhang3 xuzhang3 approved these changes

Assignees

@xuzhang3 xuzhang3

Labels
documentation-pr Improvements or additions to documentation medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to specify more than 2 DNS servers in the azure_rm_virtualnetwork module.
3 participants
@kmj251 @Fred-sun @xuzhang3