Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure_rm_privatednsrecordset: fix updating SOA record #1058

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

akira6592
Copy link
Contributor

SUMMARY

Similar to #1047, there was a conversion error in Private DNS Zone. So, fix type convert error in updating SOA record.

Note that host and serial_number cannot be updated. refer to https://github.com/MicrosoftDocs/azure-docs/issues/93705#issuecomment-1142728557

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • azure_rm_privatednsrecordset
ADDITIONAL INFORMATION

integration test works fine in my local as bellow.

TASK [azure_rm_privatednsrecordset : Update SOA record] ************************
changed: [testhost] => {"changed": true, "state": {"etag": "xxx", "fqdn": "5537db84e886c87719744.com.", "id": "/subscriptions/xxx/resourceGroups/myrg/providers/Microsoft.Network/privateDnsZones/5537db84e886c87719744.com/SOA/@", "is_auto_registered": false, "name": "@", "soa_record": {"email": "azureprivatedns-host99.example.com", "expire_time": 2419299, "host": "azureprivatedns.net", "minimum_ttl": 399, "refresh_time": 3699, "retry_time": 399, "serial_number": 1}, "ttl": 3600, "type": "SOA"}}

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged medium_priority Medium priority labels Dec 27, 2022
@xuzhang3
Copy link
Collaborator

@akira6592 LGTM

@xuzhang3 xuzhang3 merged commit db3ab32 into ansible-collections:dev Jan 12, 2023
@akira6592
Copy link
Contributor Author

Thank you for the merge.

@akira6592 akira6592 deleted the fix-private-dns branch January 12, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants