Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure_rm_keyvaultsecret - Recover before update #1145

Closed
nioertel opened this issue Apr 17, 2023 · 3 comments · Fixed by #1489
Closed

azure_rm_keyvaultsecret - Recover before update #1145

nioertel opened this issue Apr 17, 2023 · 3 comments · Fixed by #1489
Labels
has_pr PR fixes have been made medium_priority Medium priority new_feature New feature requirments

Comments

@nioertel
Copy link

SUMMARY

Currently the following fails if the secret already exists but is in deleted (recoverable) state:

- name: Create a secret
  azure_rm_keyvaultsecret:
    secret_name: MySecret
    secret_value: My_Pass_Sec
    keyvault_uri: https://contoso.vault.azure.net/

It would be nice if this state is handled by the Ansible module (either automagically or optionally with an additional parameter recover_if_needed).

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

azure_rm_keyvaultsecret

ADDITIONAL INFORMATION

In our setup sometimes manual interactions happen with Key Vault. If someone deletes a secret that is set via Ansible, our scripts fail in the next run with KeyVaultErrorException: (Conflict) Secret ... is currently in a deleted but recoverable state.

I am happy to prepare a PR if this is a feature that you'd like to support.

@Fred-sun
Copy link
Collaborator

Fred-sun commented Apr 19, 2023

@nioertel Welcome to submit PR. I will review your submitted PR and merge it into repo. Thanks!

@Fred-sun Fred-sun added question Further information is requested medium_priority Medium priority work in In trying to solve, or in working with contributors labels Apr 19, 2023
@Fred-sun
Copy link
Collaborator

@nioertel Are you still preparing this PR? Your contribution is welcome!

@nioertel
Copy link
Author

I couldn't find time yet to work on this.

I still believe the feature is very important and would like to keep the issue open. If anyone else can/wants to pick it up in the meantime, that would be great.
Otherwise I'd give an update once I find time to work on it.

Fred-sun added a commit to Fred-sun/ansible_collections_azure that referenced this issue Oct 30, 2023
@Fred-sun Fred-sun reopened this Oct 30, 2023
@Fred-sun Fred-sun added has_pr PR fixes have been made new_feature New feature requirments and removed work in In trying to solve, or in working with contributors question Further information is requested labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has_pr PR fixes have been made medium_priority Medium priority new_feature New feature requirments
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants