-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure_rm_webapp framework support #1124
Comments
@watsonb Thank you very much for reporting this problem, which seems to be caused by service changes. I can confirm that the windows system supports python2.7, but does not support python3.10. I need to consider how to deal with it. You are also welcome to improve this problem or put forward valuable suggestions, thank you very much! |
@Fred-sun greetings. My primary goal here was to be able to deploy a Python 3.10 framework onto a Linux-based App Service Plan. After installing self.supported_linux_frameworks = ['ruby', 'php', 'dotnetcore', 'node', 'java'] to self.supported_linux_frameworks = ['ruby', 'php', 'python', 'dotnetcore', 'node', 'java'] Prior to this change, I deployed a webapp with the After I made the above code change, updated my inventory to change the framework from This seems like a simple one-line change to built-in error checking. As for enhanced error checking on versions, I feel that would be difficult to keep up with given the speed of changes to Azure. I would "leave it as an exercise to the end user" to understand what versions of frameworks are supported on App Service Plan platforms. That being said, I would update documentation to refer to correct version schemes for Python (e.g. 2.7, 3.8, 3.10) and encourage end users to pass these versions in as a string (e.g. '3.10' instead of 3.10) as this module will treat the non-string 3.10 as a float and actually pass 3.1 to Azure. I have NOT tested Python 2.7 on Windows at this time, but it is something I can test later on today. I can try to fork this repo, make the code changes, and submit a PR. But I just wanted to point this out in the event I am too bogged down with other work to do it. |
@watsonb Thanks for your comments, and you're welcome to contribute! |
I've submitted PR #1128 |
SUMMARY
Cannot deploy an Azure WebApp running in a Linux App Service Plan with a
python
framework. Moreover, the versions of Python supported by the Azure WebApp Frameworks seem to be incorrect.The module documentation and behavior seem to be opposite of the experience used when using portal.azure.com GUI. In the GUI, Linux is the only platform that supports Python, but this module's doc/behavior indicate that Windows is the only platform that supports Python.
GUI User Experience

Ansible Doc Experience

Ansible Doc Python version oddity

I would expect Python versions to be 2.x/3.x. It seems the documentation has a typo.
Line 553 in azure_rm_webapp.py seems to confirm my issue.
ISSUE TYPE
COMPONENT NAME
azure_rm_webapp
ANSIBLE VERSION
COLLECTION VERSION
However documentation/code from 1.15.0 and dev branch remain the same.
CONFIGURATION
OS / ENVIRONMENT
Running from Ubuntu 20.04 and targeting Azure.
STEPS TO REPRODUCE
EXPECTED RESULTS
I expect to be able to deploy a web app to a Linux App Service Plan with Python framework support that is consistent with the Azure Portal GUI experience.
ACTUAL RESULTS
I also note in the above that whilst I specified
The module output seems to have truncated the floating point number 3.10 down to 3.1. Perhaps this must, in fact, be a string value?
The text was updated successfully, but these errors were encountered: