Use the password plug-in to generate a login key (#1699)

* Use the password plug-in to generate a login key * small change
ansible-collections · Sep 3, 2024 · 76cea6c · 76cea6c
1 parent 97620f0
commit 76cea6c
Show file tree

Hide file tree

Showing 29 changed files with 103 additions and 86 deletions.
diff --git a/plugins/modules/azure_rm_appgateway.py b/plugins/modules/azure_rm_appgateway.py
@@ -1126,7 +1126,7 @@
       policy_name: "ssl_policy20170401_s"
     ssl_certificates:
       - name: ssl_cert
-        password: your-password
+        password: "{{ password }}"
         data: "{{ lookup('file', 'certfile') }}"
     gateway_ip_configurations:
       - subnet:
@@ -1248,7 +1248,7 @@
       policy_name: ssl_policy20170401_s
     ssl_certificates:
       - name: ssl_cert
-        password: your-password
+        password: "{{ password }}"
         data: "{{ lookup('file', ssl_cert) }}"
     gateway_ip_configurations:
       - subnet:

diff --git a/plugins/modules/azure_rm_devtestlabvirtualmachine.py b/plugins/modules/azure_rm_devtestlabvirtualmachine.py
@@ -169,7 +169,7 @@
     os_type: linux
     vm_size: Standard_A2_v2
     user_name: vmadmin
-    password: ZSuppas$$21!
+    password: "{{ password }}"
     lab_subnet:
       name: myvnSubnet
       virtual_network_name: myvn

diff --git a/plugins/modules/azure_rm_hdinsightcluster.py b/plugins/modules/azure_rm_hdinsightcluster.py
@@ -162,7 +162,7 @@
     cluster_definition:
       kind: spark
       gateway_rest_username: http-user
-      gateway_rest_password: MuABCPassword!!@123
+      gateway_rest_password: "{{ password }}"
     storage_accounts:
       - name: myStorageAccount.blob.core.windows.net
         is_default: true
@@ -174,13 +174,13 @@
         vm_size: Standard_D3
         linux_profile:
           username: sshuser
-          password: MuABCPassword!!@123
+          password: "{{ password }}"
       - name: workernode
         target_instance_count: 2
         vm_size: Standard_D3
         linux_profile:
           username: sshuser
-          password: MuABCPassword!!@123
+          password: "{{ password }}"
 '''
 
 RETURN = '''

diff --git a/plugins/modules/azure_rm_mariadbserver.py b/plugins/modules/azure_rm_mariadbserver.py
@@ -116,7 +116,7 @@
     enforce_ssl: true
     version: 10.2
     admin_username: cloudsa
-    admin_password: password
+    admin_password: "{{ password }}"
 '''
 
 RETURN = '''

diff --git a/plugins/modules/azure_rm_mysqlserver.py b/plugins/modules/azure_rm_mysqlserver.py
@@ -148,7 +148,7 @@
     enforce_ssl: true
     version: 5.7
     admin_username: cloudsa
-    admin_password: password
+    admin_password: "{{ password }}"
 '''
 
 RETURN = '''

diff --git a/plugins/modules/azure_rm_postgresqlflexibleserver.py b/plugins/modules/azure_rm_postgresqlflexibleserver.py
@@ -260,7 +260,7 @@
       name: Standard_B1ms
       tier: Burstable
     administrator_login: azureuser
-    administrator_login_password: Fred@0329
+    administrator_login_password: "{{ password }}"
     version: 12
     storage:
       storage_size_gb: 128

diff --git a/plugins/modules/azure_rm_postgresqlserver.py b/plugins/modules/azure_rm_postgresqlserver.py
@@ -146,7 +146,7 @@
     enforce_ssl: true
     storage_autogrow: true
     admin_username: cloudsa
-    admin_password: password
+    admin_password: "{{ password }}"
 '''
 
 RETURN = '''

diff --git a/plugins/modules/azure_rm_sqlmanagedinstance.py b/plugins/modules/azure_rm_sqlmanagedinstance.py
@@ -236,7 +236,7 @@
     identity:
       type: SystemAssigned
     administrator_login: azureuser
-    administrator_login_password: Ft@password0329test
+    administrator_login_password: "{{ password }}"
     storage_size_in_gb: 256
     v_cores: 8
 

diff --git a/plugins/modules/azure_rm_sqlserver.py b/plugins/modules/azure_rm_sqlserver.py
@@ -156,14 +156,14 @@
     name: server_name
     location: westus
     admin_username: mylogin
-    admin_password: Testpasswordxyz12!
+    admin_password: "{{ password }}"
 
 - name: Change SQL Server admin password
   azure_rm_sqlserver:
     resource_group: myResourceGroup
     name: server_name
     location: westus
-    admin_password: NewPasswordx123!
+    admin_password: "{{ password }}"
     change_admin_password: true
 
 - name: Create SQL Server with Azure Active Directory admin
@@ -172,7 +172,7 @@
     name: server_name
     location: westus
     admin_username: mylogin
-    admin_password: Testpasswordxyz12!
+    admin_password: "{{ password }}"
     administrators:
       principal_type: Group
       login: MySqlAdminGroup

diff --git a/plugins/modules/azure_rm_webapp.py b/plugins/modules/azure_rm_webapp.py
@@ -491,7 +491,7 @@
       name: ansible/ubuntu1404
       registry_server_url: myregistry.io
       registry_server_user: user
-      registry_server_password: pass
+      registry_server_password: "{{ password }}"
 
 - name: Create a multi-container web app
   azure_rm_webapp:

diff --git a/tests/integration/targets/azure_rm_adapplication/tasks/main.yml b/tests/integration/targets/azure_rm_adapplication/tasks/main.yml
@@ -1,6 +1,7 @@
 - name: Set display name variable
   ansible.builtin.set_fact:
     display_name: "test_app_{{ 999999999999999999994 | random | to_uuid }}"
+    password: "{{ lookup('ansible.builtin.password', '/dev/null', chars=['ascii_letters', 'digits', 'punctuation'], length=13) }}"
   run_once: true
 
 - name: Get full list from ad app info
@@ -40,7 +41,7 @@
         description: "for app role test"
         display_name: "{{ display_name }}_approle"
         is_enabled: true
-        value: Password@0329
+        value: "{{ password }}"
     optional_claims:
       access_token_claims:
         - name: aud

diff --git a/tests/integration/targets/azure_rm_appgateway/tasks/main.yml b/tests/integration/targets/azure_rm_appgateway/tasks/main.yml
@@ -1,6 +1,7 @@
 - name: Gather Resource Group info
   azure.azcollection.azure_rm_resourcegroup_info:
     name: "{{ resource_group }}"
+    password: "{{ lookup('ansible.builtin.password', '/dev/null', chars=['ascii_letters', 'digits', 'punctuation'], length=12) }}"
   register: __rg_info
 
 - name: Prepare random number
@@ -82,7 +83,7 @@
       policy_name: "ssl_policy20170401_s"
     ssl_certificates:
       - name: cert2
-        password: your-password
+        password: "{{ password }}"
         data: "{{ lookup('file', cert2_file) }}"
     gateway_ip_configurations:
       - subnet:
@@ -237,7 +238,7 @@
       policy_name: "ssl_policy20170401_s"
     ssl_certificates:
       - name: cert2
-        password: your-password
+        password: "{{ password }}"
         data: "{{ lookup('file', cert2_file) }}"
     gateway_ip_configurations:
       - subnet:
@@ -392,7 +393,7 @@
       policy_name: "ssl_policy20170401_s"
     ssl_certificates:
       - name: cert2
-        password: your-password
+        password: "{{ password }}"
         data: "{{ lookup('file', cert2_file) }}"
     gateway_ip_configurations:
       - subnet:
@@ -550,7 +551,7 @@
       policy_name: "ssl_policy20170401_s"
     ssl_certificates:
       - name: cert2
-        password: your-password
+        password: "{{ password }}"
         data: "{{ lookup('file', cert2_file) }}"
     gateway_ip_configurations:
       - subnet:
@@ -713,7 +714,7 @@
       policy_name: "ssl_policy20170401_s"
     ssl_certificates:
       - name: cert2
-        password: your-password
+        password: "{{ password }}"
         data: "{{ lookup('file', cert2_file) }}"
     gateway_ip_configurations:
       - subnet:
@@ -879,7 +880,7 @@
       policy_name: "ssl_policy20170401_s"
     ssl_certificates:
       - name: cert2
-        password: your-password
+        password: "{{ password }}"
         data: "{{ lookup('file', cert2_file) }}"
     trusted_root_certificates:
       - name: "rootCert3"
@@ -1047,7 +1048,7 @@
       policy_name: "ssl_policy20170401_s"
     ssl_certificates:
       - name: cert2
-        password: your-password
+        password: "{{ password }}"
         data: "{{ lookup('file', cert2_file) }}"
     trusted_root_certificates:
       - name: "rootCert3"
@@ -1218,7 +1219,7 @@
       policy_name: "ssl_policy20170401_s"
     ssl_certificates:
       - name: cert2
-        password: your-password
+        password: "{{ password }}"
         data: "{{ lookup('file', cert2_file) }}"
     gateway_ip_configurations:
       - subnet:
@@ -1382,7 +1383,7 @@
       policy_name: "ssl_policy20170401_s"
     ssl_certificates:
       - name: cert2
-        password: your-password
+        password: "{{ password }}"
         data: "{{ lookup('file', cert2_file) }}"
     gateway_ip_configurations:
       - subnet:

diff --git a/tests/integration/targets/azure_rm_deployment/tasks/main.yml b/tests/integration/targets/azure_rm_deployment/tasks/main.yml
@@ -1,6 +1,7 @@
 - name: Create random dns label
   ansible.builtin.set_fact:
     dns_label: "test{{ resource_group | hash('md5') | truncate(16, True, '') + (65535 | random | string) }}"
+    password: "{{ lookup('ansible.builtin.password', '/dev/null', chars=['ascii_letters', 'digits', 'punctuation'], length=12) }}"
 
 - name: Error Create Azure Deploy
   azure_rm_deployment:
@@ -12,7 +13,7 @@
       adminUsername:
         value: chouseknecht
       adminPassword:
-        value: password123!
+        value: "{{ password }}"
       dnsLabelPrefix:
         value: "{{ dns_label }}"
       ubuntuOSVersion:
@@ -30,7 +31,7 @@
       adminUsername:
         value: chouseknecht
       adminPassword:
-        value: password123!
+        value: "{{ password }}"
       dnsLabelPrefix:
         value: "{{ dns_label }}"
       ubuntuOSVersion:
@@ -42,7 +43,7 @@
     hostname: "{{ item.vm_name }}"
     ansible_host: "{{ item['ips'][0].public_ip }}"
     ansible_user: chouseknecht
-    ansible_ssh_pass: password123!
+    ansible_ssh_pass: "{{ password }}"
     groupname: azure_vms
   with_items: "{{ output.deployment.instances }}"
 

diff --git a/tests/integration/targets/azure_rm_devtestlab/tasks/main.yml b/tests/integration/targets/azure_rm_devtestlab/tasks/main.yml
@@ -1,6 +1,7 @@
 - name: Set devtest labe value
   ansible.builtin.set_fact:
     rpfx: "{{ resource_group | hash('md5') | truncate(20, True, '') }}"
+    password: "{{ lookup('ansible.builtin.password', '/dev/null', chars=['ascii_letters', 'digits', 'punctuation'], length=13) }}"
 
 - name: Create a DevTest Lab (check mode)
   azure_rm_devtestlab:
@@ -90,7 +91,7 @@
     os_type: linux
     vm_size: Standard_A2_v2
     user_name: azureuser
-    password: Password@0329
+    password: "{{ password }}"
     lab_subnet:
       name: "vnet-{{ rpfx }}Subnet"
       virtual_network_name: "vnet-{{ rpfx }}"