Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #696/b14e392a backport][stable-3] elbv2 module_util - support alb attributes and add compare method for check_mode #708

Merged
merged 1 commit into from
Mar 18, 2022
Merged

[PR #696/b14e392a backport][stable-3] elbv2 module_util - support alb attributes and add compare method for check_mode #708

merged 1 commit into from
Mar 18, 2022

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Mar 12, 2022

This is a backport of PR #696 as merged into main (b14e392).

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • community.aws.elb_application_lb
  • amazon/aws/plugins/module_utils/elbv2.py

@jatorcasso @patchback
elbv2 module_util - support alb attributes and add compare method for…
82945b9 
… check_mode (#696)

elbv2 module_util - support alb attributes and add compare method for check_mode

SUMMARY

Add support for modifying alb specific attributes for ansible-collections/community.aws#963
Add compare_elb_attributes method to support check_mode

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

community.aws.elb_application_lb
amazon/aws/plugins/module_utils/elbv2.py

Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Jill R <None>
Reviewed-by: Joseph Torcasso <None>
(cherry picked from commit b14e392)
@patchback patchback bot mentioned this pull request Mar 12, 2022
Merged
@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module_utils module_utils needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Mar 12, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Mar 14, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@alinabuzachis
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@alinabuzachis
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@alinabuzachis
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 74e4af3 into stable-3 Mar 18, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-3/b14e392a65945aead32acb78c7e5b6b852048346/pr-696 branch March 18, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module_utils module_utils new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alinabuzachis @markuman @ansibullbot @jatorcasso