ec2_key : Fix tests #427

tremble · 2021-07-31T14:09:39Z

SUMMARY

The Zuul nodes don't have OpenSSL installed on them, this breaks the generation of the fingerprints

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ec2_key

ADDITIONAL INFORMATION

https://dashboard.zuul.ansible.com/t/ansible/build/d79dcec2e3024558800bba5fd6917505/log/job-output.txt

"stderr": "/bin/sh: line 1: openssl: command not found"

Depends-on: #460

tremble · 2021-08-01T07:22:32Z

@jillr the Zuul node apparently don't have the OpenSSL CLI installed on them.

I tried working around this by using the pycrypto library, but apparently the Python 36 nodes don't have a compiler installed on them either (the 38 nodes appear to have a compiler, so I could install pycrypto)

Not sure the best way to raise an issue for the Zuul team, but we either need a compiler, or the OpenSSL CLI.

* attempt to add more information when failures occur * Use pagination and add more retry wrappers * Mark ec2_vpc_nat_gateway stable again. Using paginator and retries seems to have fixed things * Add changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@38be7f9

ansibullbot · 2021-08-07T13:04:17Z

cc @prasadkatti @s-hertel @wimnat @zbal
click here for bot help

ansible-zuul

LGTM!

* attempt to add more information when failures occur * Use pagination and add more retry wrappers * Mark ec2_vpc_nat_gateway stable again. Using paginator and retries seems to have fixed things * Add changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@38be7f9

patchback · 2022-04-20T08:46:18Z

Backport to stable-1.5: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 963a829 on top of patchback/backports/stable-1.5/963a8293c7df8e4246075b900bc3935233cb3a09/pr-427

Backporting merged PR #427 into main

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-1.5/963a8293c7df8e4246075b900bc3935233cb3a09/pr-427 upstream/stable-1.5

Now, cherry-pick PR ec2_key : Fix tests #427 contents into that branch:
```
$ git cherry-pick -x 963a8293c7df8e4246075b900bc3935233cb3a09
```
If it'll yell at you with something like fatal: Commit 963a8293c7df8e4246075b900bc3935233cb3a09 is a merge but no -m option was given., add -m 1 as follows intead:
```
$ git cherry-pick -m1 -x 963a8293c7df8e4246075b900bc3935233cb3a09
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR ec2_key : Fix tests #427 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-1.5/963a8293c7df8e4246075b900bc3935233cb3a09/pr-427

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

ec2_key : Fix tests SUMMARY The Zuul nodes don't have OpenSSL installed on them, this breaks the generation of the fingerprints ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_key ADDITIONAL INFORMATION https://dashboard.zuul.ansible.com/t/ansible/build/d79dcec2e3024558800bba5fd6917505/log/job-output.txt "stderr": "/bin/sh: line 1: openssl: command not found" Depends-on: ansible-collections#460 Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None> (cherry picked from commit 963a829)

[PR #427 backport][stable-1.5] ec2_key : Fix tests Depends-On: ansible/ansible-zuul-jobs#1498 This is a backport of PR #427 as merged into main (963a829). SUMMARY The Zuul nodes don't have OpenSSL installed on them, this breaks the generation of the fingerprints ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_key ADDITIONAL INFORMATION https://dashboard.zuul.ansible.com/t/ansible/build/d79dcec2e3024558800bba5fd6917505/log/job-output.txt "stderr": "/bin/sh: line 1: openssl: command not found" Reviewed-by: Alina Buzachis <None>

* attempt to add more information when failures occur * Use pagination and add more retry wrappers * Mark ec2_vpc_nat_gateway stable again. Using paginator and retries seems to have fixed things * Add changelog

tremble changed the title ~~Ensure openssl is available to us~~ ec2_key : Ensure openssl is available to us (tests) Jul 31, 2021

ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration needs_triage tests tests labels Jul 31, 2021

tremble force-pushed the sshkey/require-ssl branch 3 times, most recently from 90d577a to e3daa79 Compare August 1, 2021 06:31

tremble mentioned this pull request Aug 2, 2021

ec2_key tests need openssl binary #428

Closed

1 task

tremble force-pushed the sshkey/require-ssl branch from e3daa79 to 2d92873 Compare August 5, 2021 09:28

ansibullbot added the has_issue label Aug 5, 2021

tremble mentioned this pull request Aug 5, 2021

Disable ec2_key, ec2_snapshot and ec2_group tests #429

Merged

tremble force-pushed the sshkey/require-ssl branch from 2d92873 to a542c8a Compare August 7, 2021 12:03

ansibullbot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Aug 7, 2021

tremble added 2 commits August 7, 2021 14:06

Ensure openssl is available to us

95b8bac

Try again to generate EC2 key fingerprints

c37a973

tremble force-pushed the sshkey/require-ssl branch from a542c8a to 7642a13 Compare August 7, 2021 12:07

ansibullbot added community_review and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Aug 7, 2021

Try adding GCC - see if pycrypto based result works

094554c

tremble force-pushed the sshkey/require-ssl branch from 7642a13 to 094554c Compare August 7, 2021 12:29

re-enable ec2_key

042e56e

ansibullbot added the plugins plugin (any type) label Aug 7, 2021

ansible-zuul bot approved these changes Aug 12, 2021

View reviewed changes

ansible-zuul bot merged commit 963a829 into ansible-collections:main Aug 12, 2021

tremble deleted the sshkey/require-ssl branch November 26, 2021 12:42

tremble added the backport-1.5 PR should be backported to the stable-1.5 branch label Apr 20, 2022

tremble mentioned this pull request Apr 20, 2022

[PR #427 backport][stable-1.5] ec2_key : Fix tests #778

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ec2_key : Fix tests #427

ec2_key : Fix tests #427

tremble commented Jul 31, 2021 •

edited

Loading

tremble commented Aug 1, 2021

ansibullbot commented Aug 7, 2021

ansible-zuul bot left a comment

patchback bot commented Apr 20, 2022 •

edited

Loading

ec2_key : Fix tests #427

ec2_key : Fix tests #427

Conversation

tremble commented Jul 31, 2021 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

tremble commented Aug 1, 2021

ansibullbot commented Aug 7, 2021

ansible-zuul bot left a comment

Choose a reason for hiding this comment

patchback bot commented Apr 20, 2022 • edited Loading

Backport to stable-1.5: 💔 cherry-picking failed — conflicts found

Backporting merged PR #427 into main

tremble commented Jul 31, 2021 •

edited

Loading

patchback bot commented Apr 20, 2022 •

edited

Loading