Use tiny_prefix to limit the length of the 'unique' component of ELB name #406

tremble · 2021-07-18T11:17:40Z

Depends-On: ansible/ansible-zuul-jobs#1005

SUMMARY

Post Zuul migration names can now be much longer which causes problems

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ec2_elb_lb

ADDITIONAL INFORMATION

https://14d6523de9e1f2ced925-16d8b6320f45d127d2ef23bdfb3eef13.ssl.cf1.rackcdn.com/404/03f3d6b089206f7c30f4ab80681a015eb4bfe078/check/ansible-test-cloud-integration-aws-py36_0/5487ad2/job-output.txt

2021-07-16 19:10:46.097502 | fedora-34 | TASK [ec2_elb_lb : Create ELB] *************************************************
2021-07-16 19:10:46.097756 | fedora-34 | task path: /home/zuul/.ansible/collections/ansible_collections/amazon/aws/tests/integration/targets/ec2_elb_lb/tasks/main.yml:38
2021-07-16 19:10:46.157175 | fedora-34 | <testhost> ESTABLISH LOCAL CONNECTION FOR USER: zuul
2021-07-16 19:10:46.158017 | fedora-34 | <testhost> EXEC /bin/sh -c 'echo ~zuul && sleep 0'
2021-07-16 19:10:46.170693 | fedora-34 | <testhost> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /home/zuul/.ansible/tmp `"&& mkdir "` echo /home/zuul/.ansible/tmp/ansible-tmp-1626462646.1694572-6660-127468165970653 `" && echo ansible-tmp-1626462646.1694572-6660-127468165970653="` echo /home/zuul/.ansible/tmp/ansible-tmp-1626462646.1694572-6660-127468165970653 `" ) && sleep 0'
2021-07-16 19:10:46.481408 | fedora-34 | Using module file /home/zuul/.ansible/collections/ansible_collections/amazon/aws/plugins/modules/ec2_elb_lb.py
2021-07-16 19:10:46.483101 | fedora-34 | <testhost> PUT /home/zuul/.ansible/tmp/ansible-local-6563_jbynpg5/tmp49ryp_c_ TO /home/zuul/.ansible/tmp/ansible-tmp-1626462646.1694572-6660-127468165970653/AnsiballZ_ec2_elb_lb.py
2021-07-16 19:10:46.484497 | fedora-34 | <testhost> EXEC /bin/sh -c 'chmod u+x /home/zuul/.ansible/tmp/ansible-tmp-1626462646.1694572-6660-127468165970653/ /home/zuul/.ansible/tmp/ansible-tmp-1626462646.1694572-6660-127468165970653/AnsiballZ_ec2_elb_lb.py && sleep 0'
2021-07-16 19:10:46.497710 | fedora-34 | <testhost> EXEC /bin/sh -c 'ANSIBLE_DEBUG_BOTOCORE_LOGS=True /home/zuul/venv/bin/python /home/zuul/.ansible/tmp/ansible-tmp-1626462646.1694572-6660-127468165970653/AnsiballZ_ec2_elb_lb.py && sleep 0'
2021-07-16 19:10:47.937426 | fedora-34 | <testhost> EXEC /bin/sh -c 'rm -f -r /home/zuul/.ansible/tmp/ansible-tmp-1626462646.1694572-6660-127468165970653/ > /dev/null 2>&1 && sleep 0'
2021-07-16 19:10:47.957657 | fedora-34 | The full traceback is:
2021-07-16 19:10:47.957707 | fedora-34 | Traceback (most recent call last):
2021-07-16 19:10:47.957727 | fedora-34 |   File "/home/zuul/.ansible/tmp/ansible-tmp-1626462646.1694572-6660-127468165970653/AnsiballZ_ec2_elb_lb.py", line 114, in <module>
2021-07-16 19:10:47.957741 | fedora-34 |     _ansiballz_main()
2021-07-16 19:10:47.957754 | fedora-34 |   File "/home/zuul/.ansible/tmp/ansible-tmp-1626462646.1694572-6660-127468165970653/AnsiballZ_ec2_elb_lb.py", line 106, in _ansiballz_main
2021-07-16 19:10:47.957766 | fedora-34 |     invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
2021-07-16 19:10:47.957779 | fedora-34 |   File "/home/zuul/.ansible/tmp/ansible-tmp-1626462646.1694572-6660-127468165970653/AnsiballZ_ec2_elb_lb.py", line 55, in invoke_module
2021-07-16 19:10:47.957791 | fedora-34 |     run_name='__main__', alter_sys=True)
2021-07-16 19:10:47.957804 | fedora-34 |   File "/usr/lib64/python3.6/runpy.py", line 205, in run_module
2021-07-16 19:10:47.957816 | fedora-34 |     return _run_module_code(code, init_globals, run_name, mod_spec)
2021-07-16 19:10:47.957829 | fedora-34 |   File "/usr/lib64/python3.6/runpy.py", line 96, in _run_module_code
2021-07-16 19:10:47.957841 | fedora-34 |     mod_name, mod_spec, pkg_name, script_name)
2021-07-16 19:10:47.957853 | fedora-34 |   File "/usr/lib64/python3.6/runpy.py", line 85, in _run_code
2021-07-16 19:10:47.957865 | fedora-34 |     exec(code, run_globals)
2021-07-16 19:10:47.957878 | fedora-34 |   File "/tmp/ansible_ec2_elb_lb_payload_wa_368qa/ansible_ec2_elb_lb_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_elb_lb.py", line 1337, in <module>
2021-07-16 19:10:47.957896 | fedora-34 |   File "/tmp/ansible_ec2_elb_lb_payload_wa_368qa/ansible_ec2_elb_lb_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_elb_lb.py", line 1324, in main
2021-07-16 19:10:47.957910 | fedora-34 |   File "/tmp/ansible_ec2_elb_lb_payload_wa_368qa/ansible_ec2_elb_lb_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_elb_lb.py", line 378, in _do_op
2021-07-16 19:10:47.957922 | fedora-34 |   File "/tmp/ansible_ec2_elb_lb_payload_wa_368qa/ansible_ec2_elb_lb_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_elb_lb.py", line 455, in ensure_ok
2021-07-16 19:10:47.957943 | fedora-34 |   File "/tmp/ansible_ec2_elb_lb_payload_wa_368qa/ansible_ec2_elb_lb_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_elb_lb.py", line 687, in _create_elb
2021-07-16 19:10:47.957957 | fedora-34 |   File "/home/zuul/venv/lib/python3.6/site-packages/boto/ec2/elb/__init__.py", line 242, in create_load_balancer
2021-07-16 19:10:47.957970 | fedora-34 |     params, LoadBalancer)
2021-07-16 19:10:47.957982 | fedora-34 |   File "/home/zuul/venv/lib/python3.6/site-packages/boto/connection.py", line 1208, in get_object
2021-07-16 19:10:47.957995 | fedora-34 |     raise self.ResponseError(response.status, response.reason, body)
2021-07-16 19:10:47.958007 | fedora-34 | boto.exception.BotoServerError: BotoServerError: 400 Bad Request
2021-07-16 19:10:47.958019 | fedora-34 | <ErrorResponse xmlns="http://elasticloadbalancing.amazonaws.com/doc/2012-06-01/">
2021-07-16 19:10:47.958031 | fedora-34 |   <Error>
2021-07-16 19:10:47.958056 | fedora-34 |     <Type>Sender</Type>
2021-07-16 19:10:47.958069 | fedora-34 |     <Code>ValidationError</Code>
2021-07-16 19:10:47.958082 | fedora-34 |     <Message>LoadBalancer name cannot be longer than 32 characters</Message>
2021-07-16 19:10:47.958094 | fedora-34 |   </Error>
2021-07-16 19:10:47.958120 | fedora-34 |   <RequestId>ac18ee90-5355-4abb-93df-99053ff37c41</RequestId>
2021-07-16 19:10:47.958134 | fedora-34 | </ErrorResponse>
2021-07-16 19:10:47.958149 | fedora-34 |
2021-07-16 19:10:47.958162 | fedora-34 | fatal: [testhost]: FAILED! => {
2021-07-16 19:10:47.958175 | fedora-34 |     "changed": false,
2021-07-16 19:10:47.958223 | fedora-34 |     "module_stderr": "Traceback (most recent call last):\n  File \"/home/zuul/.ansible/tmp/ansible-tmp-1626462646.1694572-6660-127468165970653/AnsiballZ_ec2_elb_lb.py\", line 114, in <module>\n    _ansiballz_main()\n  File \"/home/zuul/.ansible/tmp/ansible-tmp-1626462646.1694572-6660-127468165970653/AnsiballZ_ec2_elb_lb.py\", line 106, in _ansiballz_main\n    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\n  File \"/home/zuul/.ansible/tmp/ansible-tmp-1626462646.1694572-6660-127468165970653/AnsiballZ_ec2_elb_lb.py\", line 55, in invoke_module\n    run_name='__main__', alter_sys=True)\n  File \"/usr/lib64/python3.6/runpy.py\", line 205, in run_module\n    return _run_module_code(code, init_globals, run_name, mod_spec)\n  File \"/usr/lib64/python3.6/runpy.py\", line 96, in _run_module_code\n    mod_name, mod_spec, pkg_name, script_name)\n  File \"/usr/lib64/python3.6/runpy.py\", line 85, in _run_code\n    exec(code, run_globals)\n  File \"/tmp/ansible_ec2_elb_lb_payload_wa_368qa/ansible_ec2_elb_lb_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_elb_lb.py\", line 1337, in <module>\n  File \"/tmp/ansible_ec2_elb_lb_payload_wa_368qa/ansible_ec2_elb_lb_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_elb_lb.py\", line 1324, in main\n  File \"/tmp/ansible_ec2_elb_lb_payload_wa_368qa/ansible_ec2_elb_lb_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_elb_lb.py\", line 378, in _do_op\n  File \"/tmp/ansible_ec2_elb_lb_payload_wa_368qa/ansible_ec2_elb_lb_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_elb_lb.py\", line 455, in ensure_ok\n  File \"/tmp/ansible_ec2_elb_lb_payload_wa_368qa/ansible_ec2_elb_lb_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_elb_lb.py\", line 687, in _create_elb\n  File \"/home/zuul/venv/lib/python3.6/site-packages/boto/ec2/elb/__init__.py\", line 242, in create_load_balancer\n    params, LoadBalancer)\n  File \"/home/zuul/venv/lib/python3.6/site-packages/boto/connection.py\", line 1208, in get_object\n    raise self.ResponseError(response.status, response.reason, body)\nboto.exception.BotoServerError: BotoServerError: 400 Bad Request\n<ErrorResponse xmlns=\"http://elasticloadbalancing.amazonaws.com/doc/2012-06-01/\">\n  <Error>\n    <Type>Sender</Type>\n    <Code>ValidationError</Code>\n    <Message>LoadBalancer name cannot be longer than 32 characters</Message>\n  </Error>\n  <RequestId>ac18ee90-5355-4abb-93df-99053ff37c41</RequestId>\n</ErrorResponse>\n\n",
2021-07-16 19:10:47.958245 | fedora-34 |     "module_stdout": "",
2021-07-16 19:10:47.958259 | fedora-34 |     "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error",
2021-07-16 19:10:47.958281 | fedora-34 |     "rc": 1
2021-07-16 19:10:47.958295 | fedora-34 | }

…in tests Post Zuul migration names can now be much longer which causes problems

ansibullbot · 2021-07-18T11:24:12Z

cc @jillr @jsdalton @s-hertel @wimnat
click here for bot help

tests/integration/targets/ec2_elb_lb/defaults/main.yml

goneri · 2021-07-21T15:22:50Z

recheck

goneri · 2021-07-22T09:53:02Z

recheck

Disable ec2_instance until we land: - ansible-collections#411 - ansible-collections#406 and figure out how to improve the reliabilty of the test. e.g of failure: https://890aa13aa78f6724352d-5fecf071b6e8bbf9bfb6df76861c0c6d.ssl.cf1.rackcdn.com/406/8f3c9c688f226433b44c0f21c738cf79190f49f4/check/ansible-test-cloud-integration-aws-py36_1/131d33e/job-output.txt

goneri · 2021-07-22T11:03:17Z

recheck

goneri · 2021-07-22T11:51:56Z

recheck

tests: disable ec2_instance for now Depends-On: ansible/ansible-zuul-jobs#1005 SUMMARY Disable ec2_instance until we land: #411 #406 and figure out how to improve the reliabilty of the test. e.g of failure: https://890aa13aa78f6724352d-5fecf071b6e8bbf9bfb6df76861c0c6d.ssl.cf1.rackcdn.com/406/8f3c9c688f226433b44c0f21c738cf79190f49f4/check/ansible-test-cloud-integration-aws-py36_1/131d33e/job-output.txt ISSUE TYPE Bugfix Pull Reques COMPONENT NAME tests Reviewed-by: Mark Chappell <None>

Revert "a.aws: temp turn off the integration tests" Depends-On: ansible-collections/amazon.aws#413 Depends-On: ansible-collections/amazon.aws#411 Depends-On: ansible-collections/amazon.aws#406 This reverts commit f605121aac62bf038e9b496f56fb71ea531e3d7e.

…-collections#406)

Use MD5sum to limit the length of the 'unique' component of ELB name …

c04f388

…in tests Post Zuul migration names can now be much longer which causes problems

ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration needs_triage plugins plugin (any type) python3 tests tests traceback labels Jul 18, 2021

tremble mentioned this pull request Jul 18, 2021

Remove "missing credentials" tests from ec2_group/ec2_vpc_net #405

Merged

alinabuzachis removed the needs_triage label Jul 20, 2021

goneri reviewed Jul 20, 2021

View reviewed changes

tests/integration/targets/ec2_elb_lb/defaults/main.yml Outdated Show resolved Hide resolved

tremble commented Jul 21, 2021

View reviewed changes

tests/integration/targets/ec2_elb_lb/defaults/main.yml Outdated Show resolved Hide resolved

Use tiny_prefix

8f3c9c6

goneri changed the title ~~Use MD5sum to limit the length of the 'unique' component of ELB name~~ Use tiny_prefix to limit the length of the 'unique' component of ELB name Jul 21, 2021

goneri approved these changes Jul 21, 2021

View reviewed changes

goneri added the gate label Jul 21, 2021

goneri added gate and removed gate labels Jul 21, 2021

goneri mentioned this pull request Jul 22, 2021

tests: disable ec2_instance for now #413

Merged

goneri added the CI label Jul 22, 2021

goneri added gate and removed gate labels Jul 22, 2021

goneri mentioned this pull request Jul 22, 2021

Revert "a.aws: temp turn off the integration tests" ansible/ansible-zuul-jobs#1006

Merged

goneri added gate and removed gate labels Jul 22, 2021

ansible-zuul bot merged commit c2bdb27 into ansible-collections:main Jul 22, 2021

tremble deleted the tests/name_length branch November 26, 2021 12:42

abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023

Fix data_pipeline unit test - error code not properly caught (ansible…

c326d02

…-collections#406)

abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023

Fix data_pipeline unit test - error code not properly caught (ansible…

0328133

…-collections#406)

abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023

Fix data_pipeline unit test - error code not properly caught (ansible…

5195a6c

…-collections#406)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use tiny_prefix to limit the length of the 'unique' component of ELB name #406

Use tiny_prefix to limit the length of the 'unique' component of ELB name #406

tremble commented Jul 18, 2021 •

edited by goneri

Loading

ansibullbot commented Jul 18, 2021

goneri commented Jul 21, 2021

goneri commented Jul 22, 2021

goneri commented Jul 22, 2021

goneri commented Jul 22, 2021

Use tiny_prefix to limit the length of the 'unique' component of ELB name #406

Use tiny_prefix to limit the length of the 'unique' component of ELB name #406

Conversation

tremble commented Jul 18, 2021 • edited by goneri Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibullbot commented Jul 18, 2021

goneri commented Jul 21, 2021

goneri commented Jul 22, 2021

goneri commented Jul 22, 2021

goneri commented Jul 22, 2021

tremble commented Jul 18, 2021 •

edited by goneri

Loading