ec2_vol: Fix iops setting and enforce iops/throughput parameters usage #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
There was a problem hiding this comment.
@markuman Thank you very much for working on this. I left some minor suggestions.
alinabuzachis
approved these changes
May 21, 2021
|
recheck |
1 similar comment
|
recheck |
jillr
approved these changes
Jun 2, 2021
mandar242
pushed a commit
to mandar242/amazon.aws
that referenced
this pull request
Aug 27, 2021
ansible-collections#371) ec2_vol: Fix iops setting and enforce iops/throughput parameters usage Reviewed-by: https://github.com/apps/ansible-zuul
ansible-zuul bot
pushed a commit
that referenced
this pull request
Sep 9, 2021
#371) (#479) ec2_vol: backport to stable-1.5 to fix modify_volume size option bug SUMMARY Back port to stable-1.5 to fix a bug in modify_volume, 'size' option. Fixes #471. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vol ADDITIONAL INFORMATION Required fix was done but was not applied in 1.5.0 release. For more details, please visit #471. Backports: #371 Depends-On: #491 Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ollections#371) * Fix passing an instance profile arn to ec2_launch_template If the string given on the iam_instance_profile looked like an arn, the wrong structure format was being returned. boto3 expects a dict of the format { arn: "{{ arn }}" } but the string was returned instead. This fixes this error: Couldn't create subsequent launch template version: Parameter validation failed: Invalid type for parameter LaunchTemplateData.IamInstanceProfile, value: arn:aws:iam::[...]:instance-profile/[...], type: <class 'str'>, valid types: <class 'dict'> * integration test * changelog Co-authored-by: Mark Chappell <mchappel@redhat.com>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ollections#371) * Fix passing an instance profile arn to ec2_launch_template If the string given on the iam_instance_profile looked like an arn, the wrong structure format was being returned. boto3 expects a dict of the format { arn: "{{ arn }}" } but the string was returned instead. This fixes this error: Couldn't create subsequent launch template version: Parameter validation failed: Invalid type for parameter LaunchTemplateData.IamInstanceProfile, value: arn:aws:iam::[...]:instance-profile/[...], type: <class 'str'>, valid types: <class 'dict'> * integration test * changelog Co-authored-by: Mark Chappell <mchappel@redhat.com>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ollections#371) * Fix passing an instance profile arn to ec2_launch_template If the string given on the iam_instance_profile looked like an arn, the wrong structure format was being returned. boto3 expects a dict of the format { arn: "{{ arn }}" } but the string was returned instead. This fixes this error: Couldn't create subsequent launch template version: Parameter validation failed: Invalid type for parameter LaunchTemplateData.IamInstanceProfile, value: arn:aws:iam::[...]:instance-profile/[...], type: <class 'str'>, valid types: <class 'dict'> * integration test * changelog Co-authored-by: Mark Chappell <mchappel@redhat.com>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 18, 2024
…ollections#371) * Fix passing an instance profile arn to ec2_launch_template If the string given on the iam_instance_profile looked like an arn, the wrong structure format was being returned. boto3 expects a dict of the format { arn: "{{ arn }}" } but the string was returned instead. This fixes this error: Couldn't create subsequent launch template version: Parameter validation failed: Invalid type for parameter LaunchTemplateData.IamInstanceProfile, value: arn:aws:iam::[...]:instance-profile/[...], type: <class 'str'>, valid types: <class 'dict'> * integration test * changelog Co-authored-by: Mark Chappell <mchappel@redhat.com> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@b528eaa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ec2_vol: Fix iops setting and enforce iops/throughput parameters usage
Adopted PR: #334
Fixes: #330
ISSUE TYPE
COMPONENT NAME
ec2_vol
ADDITIONAL INFORMATION