elbv2 boto3 client - implement new api for ip address type

[abikouo]

SUMMARY

implement boto3 api for elbv2 client to set ip address type on application and network load balancing

ansible-collections/community.aws#499

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

This API will be used for elb_application_xxx and elb_network_xxx modules

[tremble]

Thanks for taking the time to raise this PR. You've fallen foul of the sanity tests (mostly white-space related).

Please add a changelog fragment ( https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to ) module_utils and their APIs are as much a part of the collection as modules.

Additionally, I don't think it's necessary to make the extra describe API call, self.elb should already include this information.

[tremble]

@abikouo I've currently got limited internet access which makes testing cross-collection changes a little difficult. I'll try to take a look next week.

[jillr]

Thanks for this patch @abikouo. Is there a module bug or feature request that this change corresponds to? It would be good to understand how the new feature will be used so we can test it.

Could you please add unit tests for the new functionality to tests/unit/module_utils/test_elbv2.py? We don't have the entire utility covered yet (we didn't always require tests for AWS) but for anything new we try to add coverage so there's fewer gaps to have to cover later.

[abikouo]

Thanks for this patch @abikouo. Is there a module bug or feature request that this change corresponds to? It would be good to understand how the new feature will be used so we can test it.

Could you please add unit tests for the new functionality to tests/unit/module_utils/test_elbv2.py? We don't have the entire utility covered yet (we didn't always require tests for AWS) but for anything new we try to add coverage so there's fewer gaps to have to cover later.

Thanks @jillr for the feedback
This api is going to be used for the elb_application_xxx and elb_network_xxx modules, full details in the following PR
ansible-collections/community.aws#499

I will implement the unit tests for this module.

[jillr]

LGTM, thanks @abikouo