Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assertion way to check the AZ group_name attribute #2496

Merged
merged 2 commits into from
Feb 2, 2025
Merged

Fix assertion way to check the AZ group_name attribute #2496

merged 2 commits into from
Feb 2, 2025

Conversation

brahmanim
Copy link
Contributor

SUMMARY

Fix downstream integration test assertion failures when checking the AZ group_name attribute,
update assetion to use startswith instead of equal.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aws_az_info integration test target

ADDITIONAL INFORMATION

@brahmanim brahmanim added backport-8 PR should be backported to the stable-8 branch backport-9 labels Feb 2, 2025
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d86068b59482419ca0602a1f25fcd131

✔️ ansible-galaxy-importer SUCCESS in 4m 02s
✔️ build-ansible-collection SUCCESS in 10m 32s
✔️ ansible-test-splitter SUCCESS in 3m 58s
✔️ integration-amazon.aws-1 SUCCESS in 4m 25s
Skipped 43 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Feb 2, 2025
@tremble
Copy link
Contributor

tremble commented Feb 2, 2025

It's broken our integration tests too. I suspect Amazon's changed their APIs again. Yay

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/f2463e1e7aef4d4c93767c73a9ce791a

✔️ ansible-galaxy-importer SUCCESS in 5m 34s
✔️ build-ansible-collection SUCCESS in 10m 12s
✔️ ansible-test-splitter SUCCESS in 3m 56s
✔️ integration-amazon.aws-1 SUCCESS in 6m 07s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 5f0fa1d into ansible-collections:main Feb 2, 2025
49 checks passed
@patchback Patchback
Copy link

patchback bot commented Feb 2, 2025 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/5f0fa1d30e95d0435ea9489b2258c538ec52f422/pr-2496

Backported as #2498

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 2, 2025
@brahmanim @patchback
Fix assertion way to check the AZ group_name attribute (#2496)
6b60ab8 
SUMMARY

Fix downstream integration test assertion failures when checking the AZ group_name attribute,
update assetion to use startswith instead of equal.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

aws_az_info integration test target
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
(cherry picked from commit 5f0fa1d)
@patchback patchback bot mentioned this pull request Feb 2, 2025
Merged
@patchback Patchback
Copy link

patchback bot commented Feb 2, 2025 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/5f0fa1d30e95d0435ea9489b2258c538ec52f422/pr-2496

Backported as #2499

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 2, 2025
@brahmanim @patchback
Fix assertion way to check the AZ group_name attribute (#2496)
5c308ce 
SUMMARY

Fix downstream integration test assertion failures when checking the AZ group_name attribute,
update assetion to use startswith instead of equal.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

aws_az_info integration test target
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
(cherry picked from commit 5f0fa1d)
@patchback patchback bot mentioned this pull request Feb 2, 2025
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 2, 2025
@patchback
Fix assertion way to check the AZ group_name attribute (#2496) (#2498)
c676445 
This is a backport of PR #2496 as merged into main (5f0fa1d).
SUMMARY


Fix downstream integration test assertion failures when checking the AZ group_name attribute,
update assetion to use startswith instead of equal.
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

aws_az_info integration test target
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 2, 2025
@patchback
Fix assertion way to check the AZ group_name attribute (#2496) (#2499)
c5b0e34 
This is a backport of PR #2496 as merged into main (5f0fa1d).
SUMMARY


Fix downstream integration test assertion failures when checking the AZ group_name attribute,
update assetion to use startswith instead of equal.
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

aws_az_info integration test target
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
backport-8 PR should be backported to the stable-8 branch backport-9 mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brahmanim @tremble