route53_zone - Add support for enabling DNSSEC signing in a specific hosted zone #2421

alinabuzachis · 2024-12-11T10:37:21Z

SUMMARY

route53_zone - Add support for enabling DNSSEC signing in a specific hosted zone

Will rebase once #2412 is merged.

Closes #1976

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

route53_zone

ADDITIONAL INFORMATION

github-actions · 2024-12-11T10:40:43Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul · 2024-12-11T10:56:40Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/5bd94e7e4b2e498a8fc5ac61605d8bb1

✔️ ansible-galaxy-importer SUCCESS in 4m 38s
✔️ build-ansible-collection SUCCESS in 10m 18s
✔️ ansible-test-splitter SUCCESS in 4m 22s
✔️ integration-amazon.aws-1 SUCCESS in 5m 42s
✔️ integration-amazon.aws-2 SUCCESS in 5m 21s
Skipped 42 jobs

changelogs/fragments/20241203-route53-dnssec.yml

plugins/modules/route53_zone.py

abikouo · 2025-01-07T09:04:06Z

plugins/modules/route53_zone.py

+                try:
+                    client.enable_hosted_zone_dnssec(HostedZoneId=zone_id)
+                except (BotoCoreError, ClientError) as e:
+                    module.fail_json_aws(e, msg=f"Could not enable DNSSEC for {zone_id}")


can you move this to a dedicated function?

abikouo · 2025-01-07T09:04:51Z

plugins/modules/route53_zone.py

+                try:
+                    client.disable_hosted_zone_dnssec(HostedZoneId=zone_id)
+                except (BotoCoreError, ClientError) as e:
+                    module.fail_json_aws(e, msg=f"Could not enable DNSSEC for {zone_id}")


can you move this to a dedicated function?

softwarefactory-project-zuul · 2025-01-15T13:46:20Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/00ddea5edcff4c099a8faf22b41b7800

✔️ ansible-galaxy-importer SUCCESS in 5m 44s
✔️ build-ansible-collection SUCCESS in 10m 12s
✔️ ansible-test-splitter SUCCESS in 4m 10s
✔️ integration-amazon.aws-1 SUCCESS in 7m 22s
✔️ integration-amazon.aws-2 SUCCESS in 6m 58s
Skipped 42 jobs

softwarefactory-project-zuul · 2025-01-15T14:20:48Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e04fdca3de82480cbf33f85804525078

✔️ ansible-galaxy-importer SUCCESS in 4m 24s
✔️ build-ansible-collection SUCCESS in 10m 51s
✔️ ansible-test-splitter SUCCESS in 3m 58s
✔️ integration-amazon.aws-1 SUCCESS in 6m 50s
✔️ integration-amazon.aws-2 SUCCESS in 5m 44s
Skipped 42 jobs

softwarefactory-project-zuul · 2025-01-15T15:38:32Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/729ad21bc0d545f5b6a88483d201fd25

✔️ ansible-galaxy-importer SUCCESS in 4m 49s
✔️ build-ansible-collection SUCCESS in 10m 42s
✔️ ansible-test-splitter SUCCESS in 4m 08s
✔️ integration-amazon.aws-1 SUCCESS in 6m 36s
✔️ integration-amazon.aws-2 SUCCESS in 6m 19s
Skipped 42 jobs

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

softwarefactory-project-zuul · 2025-01-15T16:14:26Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3637eb0a70cc470b8e2e9b8142a25904

✔️ ansible-galaxy-importer SUCCESS in 3m 31s
✔️ build-ansible-collection SUCCESS in 10m 13s
✔️ ansible-test-splitter SUCCESS in 4m 03s
✔️ integration-amazon.aws-1 SUCCESS in 5m 17s
✔️ integration-amazon.aws-2 SUCCESS in 6m 04s
Skipped 42 jobs

abikouo · 2025-01-16T12:19:45Z

plugins/modules/route53_zone.py

+        # if dnssec_status == "DELETING":
+        # DNSSEC signing is in the process of being removed for the hosted zone.


Suggested change

# if dnssec_status == "DELETING":

# DNSSEC signing is in the process of being removed for the hosted zone.

I added these comments to document what's happening if dnssec_status == "DELETING":.

softwarefactory-project-zuul · 2025-01-17T09:27:57Z

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/e187ab6875794c1c92bacd0ee3e7ef11

✔️ ansible-galaxy-importer SUCCESS in 5m 04s
✔️ build-ansible-collection SUCCESS in 10m 25s
✔️ ansible-test-splitter SUCCESS in 4m 27s
✔️ integration-amazon.aws-1 SUCCESS in 6m 51s
✔️ integration-amazon.aws-2 SUCCESS in 6m 45s
Skipped 42 jobs

patchback · 2025-01-17T09:28:02Z

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/8e690f8deef7e7ee66eb98ee70ab2b6cc9b79416/pr-2421

Backported as #2474

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

…hosted zone (#2421) SUMMARY route53_zone - Add support for enabling DNSSEC signing in a specific hosted zone Will rebase once #2412 is merged. Closes #1976 ISSUE TYPE Feature Pull Request COMPONENT NAME route53_zone ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis (cherry picked from commit 8e690f8)

…hosted zone (#2421) (#2474) This is a backport of PR #2421 as merged into main (8e690f8). SUMMARY route53_zone - Add support for enabling DNSSEC signing in a specific hosted zone Will rebase once #2412 is merged. Closes #1976 ISSUE TYPE Feature Pull Request COMPONENT NAME route53_zone ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis

alinabuzachis added the backport-9 label Dec 11, 2024

abikouo requested changes Jan 7, 2025

View reviewed changes

alinabuzachis force-pushed the route53_dnssec branch 2 times, most recently from 7860313 to b28dff9 Compare January 15, 2025 13:27

alinabuzachis requested a review from abikouo January 15, 2025 14:36

alinabuzachis force-pushed the route53_dnssec branch 4 times, most recently from de7ac14 to 26071ac Compare January 15, 2025 15:20

alinabuzachis added 16 commits January 15, 2025 16:56

Add route53_ksk module

8580a53

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Add support for dnssec

5d5abe3

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Add changelog fragment

e10e6e7

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Run black and isort

96fdc4a

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Minor updates

ba8697d

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Fix sanity

99c81a9

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Update

0b800ca

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Fix

8be9f64

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Split into two PRs

ba40a3a

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Apply suggested changes

2cfaaee

Apply suggested changes

1b5028d

Modify upon review

ca4d58f

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Modify upon review

f8d098c

Use info from find_ksk

1e09674

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Return info in check_mode

b78ae26

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Update

318d4b7

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

alinabuzachis added 4 commits January 15, 2025 16:56

Apply suggestions

ac9d861

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Modify upon review

3e8ebf3

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Bring changes from route53

823186a

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Fixes

e888025

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

alinabuzachis force-pushed the route53_dnssec branch from 26071ac to e888025 Compare January 15, 2025 15:57

abikouo approved these changes Jan 16, 2025

View reviewed changes

alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Jan 17, 2025

softwarefactory-project-zuul bot merged commit 8e690f8 into ansible-collections:main Jan 17, 2025
49 checks passed

patchback bot mentioned this pull request Jan 17, 2025

[PR #2421/8e690f8d backport][stable-9] route53_zone - Add support for enabling DNSSEC signing in a specific hosted zone #2474

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

route53_zone - Add support for enabling DNSSEC signing in a specific hosted zone #2421

route53_zone - Add support for enabling DNSSEC signing in a specific hosted zone #2421

alinabuzachis commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

softwarefactory-project-zuul bot commented Dec 11, 2024

abikouo Jan 7, 2025

alinabuzachis Jan 15, 2025

abikouo Jan 7, 2025

alinabuzachis Jan 15, 2025

softwarefactory-project-zuul bot commented Jan 15, 2025

softwarefactory-project-zuul bot commented Jan 15, 2025

softwarefactory-project-zuul bot commented Jan 15, 2025

softwarefactory-project-zuul bot commented Jan 15, 2025

abikouo Jan 16, 2025

alinabuzachis Jan 16, 2025

softwarefactory-project-zuul bot commented Jan 17, 2025

patchback bot commented Jan 17, 2025 •

edited

Loading

		# if dnssec_status == "DELETING":
		# DNSSEC signing is in the process of being removed for the hosted zone.

route53_zone - Add support for enabling DNSSEC signing in a specific hosted zone #2421

route53_zone - Add support for enabling DNSSEC signing in a specific hosted zone #2421

Conversation

alinabuzachis commented Dec 11, 2024 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

github-actions bot commented Dec 11, 2024 • edited Loading

Docs Build 📝

softwarefactory-project-zuul bot commented Dec 11, 2024

abikouo Jan 7, 2025

Choose a reason for hiding this comment

alinabuzachis Jan 15, 2025

Choose a reason for hiding this comment

abikouo Jan 7, 2025

Choose a reason for hiding this comment

alinabuzachis Jan 15, 2025

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jan 15, 2025

softwarefactory-project-zuul bot commented Jan 15, 2025

softwarefactory-project-zuul bot commented Jan 15, 2025

softwarefactory-project-zuul bot commented Jan 15, 2025

abikouo Jan 16, 2025

Choose a reason for hiding this comment

alinabuzachis Jan 16, 2025

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jan 17, 2025

patchback bot commented Jan 17, 2025 • edited Loading

Backport to stable-9: 💚 backport PR created

alinabuzachis commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

patchback bot commented Jan 17, 2025 •

edited

Loading