Initial integration tests for ec2_vpc_dhcp_option #224
Conversation
Based on work started by s-hertel in ansible-collections#109
|
@s-hertel I opened a new PR for this one so you don't have to keep track of merging my changes into your branch as we iterate, let me know if you'd prefer to keep this work in 109! |
| # FIXME: module/aws randomly returns as a string or list | ||
| - dhcp_options.new_options['netbios-node-type'] in ['2', ['2']] | ||
| # found I think is false, because the options are different and no id is provided? | ||
| - dhcp_options.new_options['domain-name'] == "{{ aws_domain_name }}" |
There was a problem hiding this comment.
dhcp_options.new_options['domain-name'] is a list. This is probably the reason why the test fail here. Is this expected?
There was a problem hiding this comment.
There was a problem hiding this comment.
It depends. :) Thanks, I thought I caught all of these.
…ist or string, those from _info module are reliable.
|
Something is intermittently misbehaving when setting tags, I haven't been able to reproduce it locally yet but it's causing the unstable tests. Will have to dig into this more. |
|
@jillr Given that this is likely the module being unstable rather than the tests being flaky I'd suggest we merge these tests so we have tests for the boto2 based behaviour, and look to move this module over to boto3. Alternatively you may find that if you pass the ID of the options when setting the tags it's more stable than a 'search' based run. |
…ctions#224) * Port rds_subnet_group to boto3 * Linting fixes * Add more meaningful error messages, add changelog fragment * Remove test on mandatory args for state absent This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c19d479
…ctions#224) * Port rds_subnet_group to boto3 * Linting fixes * Add more meaningful error messages, add changelog fragment * Remove test on mandatory args for state absent This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c19d479
…ctions#224) * Port rds_subnet_group to boto3 * Linting fixes * Add more meaningful error messages, add changelog fragment * Remove test on mandatory args for state absent This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c19d479
…ctions#224) * Port rds_subnet_group to boto3 * Linting fixes * Add more meaningful error messages, add changelog fragment * Remove test on mandatory args for state absent
…ctions#224) * Port rds_subnet_group to boto3 * Linting fixes * Add more meaningful error messages, add changelog fragment * Remove test on mandatory args for state absent
…ctions#224) * Port rds_subnet_group to boto3 * Linting fixes * Add more meaningful error messages, add changelog fragment * Remove test on mandatory args for state absent
SUMMARY
Based on work started by s-hertel in #109
ISSUE TYPE
COMPONENT NAME
ec2_vpc_dhcp_option
ADDITIONAL INFORMATION