Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy 2.17 ignore to 2.18 - 2.17 has been branched #2044

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Apr 9, 2024

SUMMARY

With 2.17 now branched, devel has been bumped to "2.18", as a result we need to create ignore-2.18.txt

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

tests/sanity/ignore-2.18.txt

ADDITIONAL INFORMATION

While there is a devel/milestone error for "deprecated version", this will be fixed by #2040 (hint: please review). Because #2040 touches module_utils it triggers a lot of tests, which I'd rather not do. As such I'll leave the entry out of this PR and everything should be good again once 2040 merges.

@tremble tremble requested a review from alinabuzachis April 9, 2024 07:27
@tremble tremble marked this pull request as ready for review April 9, 2024 07:27
@tremble tremble added the backport-7 PR should be backported to the stable-7 branch label Apr 9, 2024
Copy link
Contributor

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Apr 9, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/5f2ef136baf049f1851051d508835170

✔️ ansible-galaxy-importer SUCCESS in 5m 25s
✔️ build-ansible-collection SUCCESS in 14m 00s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 425b176 into ansible-collections:main Apr 9, 2024
35 of 41 checks passed
Copy link

patchback bot commented Apr 9, 2024

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/425b176cdb86f9753b719883d6f2138158f50f67/pr-2044

Backported as #2045

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 9, 2024
Copy 2.17 ignore to 2.18 - 2.17 has been branched

SUMMARY
With 2.17 now branched, devel has been bumped to "2.18", as a result we need to create ignore-2.18.txt
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/sanity/ignore-2.18.txt
ADDITIONAL INFORMATION
While there is a devel/milestone error for "deprecated version", this will be fixed by #2040 (hint: please review).  Because #2040 touches module_utils it triggers a lot of tests, which I'd rather not do.  As such I'll leave the entry out of this PR and everything should be good again once 2040 merges.

Reviewed-by: Alina Buzachis
(cherry picked from commit 425b176)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 9, 2024
[PR #2044/425b176c backport][stable-7] Copy 2.17 ignore to 2.18 - 2.17 has been branched

This is a backport of PR #2044 as merged into main (425b176).
SUMMARY
With 2.17 now branched, devel has been bumped to "2.18", as a result we need to create ignore-2.18.txt
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/sanity/ignore-2.18.txt
ADDITIONAL INFORMATION
While there is a devel/milestone error for "deprecated version", this will be fixed by #2040 (hint: please review).  Because #2040 touches module_utils it triggers a lot of tests, which I'd rather not do.  As such I'll leave the entry out of this PR and everything should be good again once 2040 merges.

Reviewed-by: Mark Chappell
@tremble tremble deleted the ansible-2.17-branch branch June 12, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7 PR should be backported to the stable-7 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants