[PR #1883/3b67513e backport][stable-7] cloudwatchevent_rule: Fix json input handling for input_template #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudwatchevent_rule: Fix json input handling for input_template SUMMARY Fixes #1842 This PR Moves _snakify() out of class CloudWatchEventRule https://github.com/ansible-collections/amazon.aws/pull/1883/files#diff-3a2f223edc4e34ea28b9859827a830844d92a8cd97f1300a2d16b1703a083bc8R213-R215 Fixes conditional in function _targets_to_put() to avoid wrong results due to _snakify() https://github.com/ansible-collections/amazon.aws/pull/1883/files#diff-3a2f223edc4e34ea28b9859827a830844d92a8cd97f1300a2d16b1703a083bc8R461-R463 Updates code to add quotes " to input_template only when the given input is not JSON to avoid quotes being added to provided JSON input https://github.com/ansible-collections/amazon.aws/pull/1883/files#diff-3a2f223edc4e34ea28b9859827a830844d92a8cd97f1300a2d16b1703a083bc8R452-R458 ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudwatchevent_rule ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: Helen Bailey <hebailey@redhat.com> Reviewed-by: Alina Buzachis Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> (cherry picked from commit 3b67513)
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 54s |
alinabuzachis
approved these changes
Feb 12, 2024
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 41s |
4975003
into
stable-7
37 of 40 checks passed
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 18, 2024
[7.0.0] Bump botocore requirements SUMMARY In line with ansible-collections#1763 bump our botocore requirements for 7.0.0 ISSUE TYPE Feature Pull Request COMPONENT NAME README.md changelogs/fragments/botocore.yml changelogs/fragments/python37.yml plugins/modules/dynamodb_table.py plugins/modules/ec2_launch_template.py plugins/modules/networkfirewall_policy.py plugins/modules/networkfirewall_rule_group.py plugins/modules/networkfirewall_rule_group_info.py plugins/modules/opensearch.py plugins/modules/opensearch_info.py plugins/modules/s3_lifecycle.py plugins/modules/wafv2_web_acl.py requirements.txt tests/config.yml tests/integration/constraints.txt tests/unit/constraints.txt ADDITIONAL INFORMATION Deliberately links to the amazon.aws PR to avoid duplicating the reasons. Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@b753fe5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1883 as merged into main (3b67513).
SUMMARY
Fixes #1842
This PR
Moves
_snakify()out ofclass CloudWatchEventRulehttps://github.com/ansible-collections/amazon.aws/pull/1883/files#diff-3a2f223edc4e34ea28b9859827a830844d92a8cd97f1300a2d16b1703a083bc8R213-R215Fixes conditional in function
_targets_to_put()to avoid wrong results due to_snakify()https://github.com/ansible-collections/amazon.aws/pull/1883/files#diff-3a2f223edc4e34ea28b9859827a830844d92a8cd97f1300a2d16b1703a083bc8R461-R463Updates code to add quotes
"toinput_templateonly when the given input is not JSON to avoid quotes being added to provided JSON input https://github.com/ansible-collections/amazon.aws/pull/1883/files#diff-3a2f223edc4e34ea28b9859827a830844d92a8cd97f1300a2d16b1703a083bc8R452-R458ISSUE TYPE
COMPONENT NAME
cloudwatchevent_rule
ADDITIONAL INFORMATION