use ec2_ami to test ec2_snapshot_info #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
ec2_snapshot_info/tests: add unit-tests Depends-On: #1234 Depends-On: #1235 SUMMARY Add the unit-test coverage of the ec2_snapshot_info module. break up list_ec2_snapshots to move connection.describe_snapshots to separate method. COMPONENT NAME ec2_snapshot_info ADDITIONAL INFO latest CI run coverage report plugins_modules_ec2_snapshot_info_py.html Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
dms_endpoint - Support modifying tags SUMMARY Return details of the endpoint, even when not making changes add purge_tags / resource_tags with the usual behaviour Split tests Add some very basic idempotency tests support modifying tags ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME dms_endpoint ADDITIONAL INFORMATION changelog Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
dms_endpoint - Support modifying tags SUMMARY Return details of the endpoint, even when not making changes add purge_tags / resource_tags with the usual behaviour Split tests Add some very basic idempotency tests support modifying tags ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME dms_endpoint ADDITIONAL INFORMATION changelog Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
dms_endpoint - Support modifying tags SUMMARY Return details of the endpoint, even when not making changes add purge_tags / resource_tags with the usual behaviour Split tests Add some very basic idempotency tests support modifying tags ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME dms_endpoint ADDITIONAL INFORMATION changelog Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.