Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version_added information for modules which migrate to amazon.aws in 5.0.0 #1155

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 11, 2022

SUMMARY

Felix has pointed out in IRC/Matrix that for modules which migrated to amazon.aws it can be a little confusing when you try to look back in logs to find exactly what needs to be installed for a feature (installing amazon.aws.4.3.0 doesn't guarantee that community.aws 4.x is installed)

Update the main 'version_added' to match the version that the modules were moved to amazon.aws, and add the version_added_collection for existing new features.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

various modules

ADDITIONAL INFORMATION

Scope is currently limited to the 5.0.0 migrations, to simplify backports. If accepted I'll cleanup the 4.0.0 and 2.0.0 modules too.

@tremble tremble requested a review from alinabuzachis October 11, 2022 16:05
@tremble
Copy link
Contributor Author

tremble commented Oct 11, 2022

CC: @felixfontein

@github-actions
Copy link

github-actions bot commented Oct 11, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot ansibullbot added community_review docs module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Oct 11, 2022
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Oct 11, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 5m 19s
✔️ build-ansible-collection SUCCESS in 7m 25s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 11m 12s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 32s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 11m 05s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 9m 03s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 49s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 8m 41s
✔️ cloud-tox-py3 SUCCESS in 4m 11s
✔️ ansible-test-splitter SUCCESS in 3m 52s
✔️ integration-amazon.aws-1 SUCCESS in 33m 39s
✔️ integration-amazon.aws-2 SUCCESS in 9m 43s
✔️ integration-amazon.aws-3 SUCCESS in 49m 13s
✔️ integration-amazon.aws-4 SUCCESS in 25m 46s
✔️ integration-amazon.aws-5 SUCCESS in 40m 58s
✔️ integration-amazon.aws-6 SUCCESS in 24m 01s
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 3m 16s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 2797554 into ansible-collections:main Oct 11, 2022
@tremble tremble added the backport-5 PR should be backported to the stable-5 branch label Oct 11, 2022
@patchback
Copy link

patchback bot commented Oct 11, 2022

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/27975542f2d25017eea69d7a69b6d1dbc96a5e3c/pr-1155

Backported as #1157

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 11, 2022
…aws in 5.0.0 (#1155)

Update version_added information for modules which migrate to amazon.aws in 5.0.0

SUMMARY
Felix has pointed out in IRC/Matrix that for modules which migrated to amazon.aws it can be a little confusing when you try to look back in logs to find exactly what needs to be installed for a feature (installing amazon.aws.4.3.0 doesn't guarantee that community.aws 4.x is installed)
Update the main 'version_added' to match the version that the modules were moved to amazon.aws, and add the version_added_collection for existing new features.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various modules
ADDITIONAL INFORMATION
Scope is currently limited to the 5.0.0 migrations, to simplify backports.  If accepted I'll cleanup the 4.0.0 and 2.0.0 modules too.

Reviewed-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 2797554)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 12, 2022
…aws in 5.0.0 (#1155) (#1157)

[PR #1155/27975542 backport][stable-5] Update version_added information for modules which migrate to amazon.aws in 5.0.0

Depends-On: ansible/ansible-zuul-jobs#1660
This is a backport of PR #1155 as merged into main (2797554).
SUMMARY
Felix has pointed out in IRC/Matrix that for modules which migrated to amazon.aws it can be a little confusing when you try to look back in logs to find exactly what needs to be installed for a feature (installing amazon.aws.4.3.0 doesn't guarantee that community.aws 4.x is installed)
Update the main 'version_added' to match the version that the modules were moved to amazon.aws, and add the version_added_collection for existing new features.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
various modules
ADDITIONAL INFORMATION
Scope is currently limited to the 5.0.0 migrations, to simplify backports.  If accepted I'll cleanup the 4.0.0 and 2.0.0 modules too.

Reviewed-by: Mark Chappell <None>
@tremble tremble deleted the version_added_collection branch October 21, 2022 07:33
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…ss tokens (ansible-collections#1155)

Add changelog for profile becoming mutually exclusive with other access tokens

Depends-On: ansible-collections#834
SUMMARY
amazon.aws/834 made profile mutually exclusive with the other access token parameters, add a changelog fragment to community.aws since it's a significant change that also affects this collection
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
changelogs/fragments/151-profile-mutually-exclusive.yml
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-5 PR should be backported to the stable-5 branch community_review docs mergeit Merge the PR (SoftwareFactory) module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants