-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version_added information for modules which migrate to amazon.aws in 5.0.0 #1155
Merged
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:main
from
tremble:version_added_collection
Oct 11, 2022
Merged
Update version_added information for modules which migrate to amazon.aws in 5.0.0 #1155
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:main
from
tremble:version_added_collection
Oct 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CC: @felixfontein |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
felixfontein
approved these changes
Oct 11, 2022
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1157 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 11, 2022
…aws in 5.0.0 (#1155) Update version_added information for modules which migrate to amazon.aws in 5.0.0 SUMMARY Felix has pointed out in IRC/Matrix that for modules which migrated to amazon.aws it can be a little confusing when you try to look back in logs to find exactly what needs to be installed for a feature (installing amazon.aws.4.3.0 doesn't guarantee that community.aws 4.x is installed) Update the main 'version_added' to match the version that the modules were moved to amazon.aws, and add the version_added_collection for existing new features. ISSUE TYPE Docs Pull Request COMPONENT NAME various modules ADDITIONAL INFORMATION Scope is currently limited to the 5.0.0 migrations, to simplify backports. If accepted I'll cleanup the 4.0.0 and 2.0.0 modules too. Reviewed-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 2797554)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Oct 12, 2022
…aws in 5.0.0 (#1155) (#1157) [PR #1155/27975542 backport][stable-5] Update version_added information for modules which migrate to amazon.aws in 5.0.0 Depends-On: ansible/ansible-zuul-jobs#1660 This is a backport of PR #1155 as merged into main (2797554). SUMMARY Felix has pointed out in IRC/Matrix that for modules which migrated to amazon.aws it can be a little confusing when you try to look back in logs to find exactly what needs to be installed for a feature (installing amazon.aws.4.3.0 doesn't guarantee that community.aws 4.x is installed) Update the main 'version_added' to match the version that the modules were moved to amazon.aws, and add the version_added_collection for existing new features. ISSUE TYPE Docs Pull Request COMPONENT NAME various modules ADDITIONAL INFORMATION Scope is currently limited to the 5.0.0 migrations, to simplify backports. If accepted I'll cleanup the 4.0.0 and 2.0.0 modules too. Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ss tokens (ansible-collections#1155) Add changelog for profile becoming mutually exclusive with other access tokens Depends-On: ansible-collections#834 SUMMARY amazon.aws/834 made profile mutually exclusive with the other access token parameters, add a changelog fragment to community.aws since it's a significant change that also affects this collection ISSUE TYPE Feature Pull Request COMPONENT NAME changelogs/fragments/151-profile-mutually-exclusive.yml ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-5
PR should be backported to the stable-5 branch
community_review
docs
mergeit
Merge the PR (SoftwareFactory)
module
module
needs_triage
owner_pr
PR created by owner/maintainer
plugins
plugin (any type)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Felix has pointed out in IRC/Matrix that for modules which migrated to amazon.aws it can be a little confusing when you try to look back in logs to find exactly what needs to be installed for a feature (installing amazon.aws.4.3.0 doesn't guarantee that community.aws 4.x is installed)
Update the main 'version_added' to match the version that the modules were moved to amazon.aws, and add the version_added_collection for existing new features.
ISSUE TYPE
COMPONENT NAME
various modules
ADDITIONAL INFORMATION
Scope is currently limited to the 5.0.0 migrations, to simplify backports. If accepted I'll cleanup the 4.0.0 and 2.0.0 modules too.