new modules: lambda_layer and lambda_layer_info #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
previously requested changes
Sep 30, 2022
There was a problem hiding this comment.
Please see https://ansible-collections.github.io/amazon.aws/branch/main/collections/amazon/aws/docsite/dev_guidelines.html#api-throttling-rate-limiting-and-pagination for more information about using AWSRetry.
I'm not a big fan of unit tests which just call the "main" function (execute_module). I don't see a reason why we can't do integration tests here. (unlike some of the IAM/CloudWatch modules where there are security concerns). Tests like this will just be very fragile and need to be re-written with any significant change to the module.
alinabuzachis
previously requested changes
Oct 3, 2022
goneri
suggested changes
Oct 11, 2022
goneri
approved these changes
Oct 11, 2022
goneri
reviewed
Oct 11, 2022
goneri
reviewed
Oct 11, 2022
goneri
reviewed
Oct 11, 2022
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
…tions (#1118) lambda - add support for layers when creating or updating lambda functions Depends-On: #1095 SUMMARY add the ability for module lambda to create/update a lambda function with layers attached ISSUE TYPE Feature Pull Request COMPONENT NAME lambda ADDITIONAL INFORMATION - lambda: name: test-func runtime: python3.7 (...) layers: - layer_version_arn: 'arn:aws:lambda:us-east-1:123456789012:layer:python27-env:7' - layer_name: pycustom-library version: 1 Reviewed-by: Alina Buzachis <None> Reviewed-by: Bikouo Aubin <None>
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Apr 27, 2023
…tions (ansible-collections#1118) lambda - add support for layers when creating or updating lambda functions Depends-On: ansible-collections#1095 SUMMARY add the ability for module lambda to create/update a lambda function with layers attached ISSUE TYPE Feature Pull Request COMPONENT NAME lambda ADDITIONAL INFORMATION - lambda: name: test-func runtime: python3.7 (...) layers: - layer_version_arn: 'arn:aws:lambda:us-east-1:123456789012:layer:python27-env:7' - layer_name: pycustom-library version: 1 Reviewed-by: Alina Buzachis <None> Reviewed-by: Bikouo Aubin <None>
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Apr 28, 2023
…1095) new modules: lambda_layer and lambda_layer_info SUMMARY The module lambda_layer allows user to publish or delete lambda layer version, while lambda_layer_info is used to list lambda layers or all versions of a specific lambda layer ISSUE TYPE New Module Pull Request COMPONENT NAME lambda_layer lambda_layer_info ADDITIONAL INFORMATION Closes: ansible-collections#1116 Reviewed-by: Mark Chappell <None> Reviewed-by: Bikouo Aubin <None> Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 3, 2023
…_info (#1095) (#1495) [manual backport stable-5] new modules: lambda_layer and lambda_layer_info (#1095) new modules: lambda_layer and lambda_layer_info SUMMARY The module lambda_layer allows user to publish or delete lambda layer version, while lambda_layer_info is used to list lambda layers or all versions of a specific lambda layer ISSUE TYPE New Module Pull Request COMPONENT NAME lambda_layer lambda_layer_info ADDITIONAL INFORMATION Closes: #1116 Reviewed-by: Mark Chappell Reviewed-by: Bikouo Aubin Reviewed-by: Jill R Reviewed-by: Alina Buzachis Reviewed-by: Gonéri Le Bouder goneri@lebouder.net SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 3, 2023
…tions (#1118) (#1492) [manual backport stable-5] lambda - add support for layers when creating or updating lambda functions (#1118) lambda - add support for layers when creating or updating lambda functions Depends-On: #1095 SUMMARY add the ability for module lambda to create/update a lambda function with layers attached ISSUE TYPE Feature Pull Request COMPONENT NAME lambda ADDITIONAL INFORMATION lambda: name: test-func runtime: python3.7 (...) layers: - layer_version_arn: 'arn:aws:lambda:us-east-1:123456789012:layer:python27-env:7' - layer_name: pycustom-library version: 1 Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The module
lambda_layerallows user to publish or delete lambda layer version, whilelambda_layer_infois used to list lambda layers or all versions of a specific lambda layerISSUE TYPE
COMPONENT NAME
lambda_layer
lambda_layer_info
ADDITIONAL INFORMATION
Closes: #1116