Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SSHFP records #2413

Closed
1 task done
betelgeuse opened this issue Dec 4, 2024 · 1 comment · Fixed by #2430
Closed
1 task done

Support SSHFP records #2413

betelgeuse opened this issue Dec 4, 2024 · 1 comment · Fixed by #2430
Assignees
@mandar242
Labels
jira waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@betelgeuse
Copy link

Summary

Route53 supports SSHFP records:

https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/ResourceRecordTypes.html?icmpid=docs_console_unmapped

However, the code base has a hard coded list of supported record types:

amazon.aws/plugins/modules/route53.py

Line 561 in e178256

choices=["A", "AAAA", "CAA", "CNAME", "MX", "NS", "PTR", "SOA", "SPF", "SRV", "TXT"],

Issue Type

Feature Idea

Component Name

route53

Additional Information



Code of Conduct


    

  •  I agree to follow the Ansible Code of Conduct
    • 


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            


    







      

  
      



  

  @hakbailey





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
Hi @betelgeuse, thanks for submitting this issue. Any chance you'd be willing to open a PR for it?

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @hakbailey
hakbailey




          added
  the 

  waiting_on_contributor

  Needs help. Feel free to engage to get things unblocked
 label


      Dec 10, 2024

    

  



    

    

      
    

    


      

          @mandar242
mandar242




              self-assigned this


      Dec 23, 2024

    

  



  

  

    
  


  

      

    @mandar242
mandar242



    mentioned this issue
    
      Dec 23, 2024
    





  


  

      
   Merged

  







  




    

    


    

    


  


  
    
  
  

    
  patchback bot

      pushed a commit
      that referenced
      this issue

    
      Jan 9, 2025
    
    

      


  

    

      


  

      
        @mandar242
      
        @patchback
  





      

        
          route53: add support for type SSHFP (#2430)
        

          
            
          

      


      

          

    
    
    

  

      


      

          

    
    
    

  

  

    
  



      


      
      

        
          59fcd74
        
      

    

  

    

      
SUMMARY

Fixes #2413
Adds support for record type 'SSHFP'

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

route53
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <gomathiselvi@gmail.com>
Reviewed-by: Bikouo Aubin
(cherry picked from commit c185dc3)

    




    

  




  

  

    
  


  

      

    @patchback
patchback
bot


    mentioned this issue
    
      Jan 9, 2025
    





  


  

      
   Merged

  







  




  
  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Jan 14, 2025
    
    

      


  

    

      


  

      
        @patchback
  





      

        
          route53: add support for type SSHFP (#2430) (#2445)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          919666c
        
      

    

  

    

      
This is a backport of PR #2430 as merged into main (c185dc3).
SUMMARY

Fixes #2413
Adds support for record type 'SSHFP'

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

route53
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell

    




    

  




  


  
    
  
  

    
  alinabuzachis 

      pushed a commit
        to alinabuzachis/amazon.aws
      that referenced
      this issue

    
      Jan 15, 2025
    
    

      


  

    

      


  

      
        @mandar242
      
        @alinabuzachis
  





      

        
          route53: add support for type SSHFP (ansible-collections#2430)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          3091a16
        
      

    

  

    

      
SUMMARY

Fixes ansible-collections#2413
Adds support for record type 'SSHFP'

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

route53
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <gomathiselvi@gmail.com>
Reviewed-by: Bikouo Aubin

    




    

  




  


  
    
  
  

    
  alinabuzachis 

      pushed a commit
        to alinabuzachis/amazon.aws
      that referenced
      this issue

    
      Jan 15, 2025
    
    

      


  

    

      


  

      
        @mandar242
      
        @alinabuzachis
  





      

        
          route53: add support for type SSHFP (ansible-collections#2430)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          a94f084
        
      

    

  

    

      
SUMMARY

Fixes ansible-collections#2413
Adds support for record type 'SSHFP'

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

route53
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <gomathiselvi@gmail.com>
Reviewed-by: Bikouo Aubin

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @mandar242
  
    mandar242
    

      








      


  


  

    Labels
  



    

      

    jira

  

    waiting_on_contributor

  Needs help. Feel free to engage to get things unblocked








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
    

    Development
  




            
  
Successfully merging a pull request may close this issue.





    


  
          
      route53: add support for type SSHFP

    
      mandar242/amazon.aws
    





      
    

  




      

    

  
      

  

    

      3 participants
    

    

        
          @betelgeuse 
        
          @hakbailey 
        
          @mandar242