Return documented things in channel_code_parts and don't throw errors #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d164e30 to
df55731
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 87.94% 88.07% +0.12%
==========================================
Files 7 7
Lines 282 285 +3
==========================================
+ Hits 248 251 +3
Misses 34 34 ☔ View full report in Codecov by Sentry. |
Previously, `channel_code_parts`'s returned elements of a channel code as `nothing` if they were empty in a miniSEED code string, or if the format was not as expected. However, the docstring actually stated they would be 'empty', meaning empty strings. Update the behaviour to match that documented. At the same time, also stop erroring when encountering a channel code which for any reason does not fit the expected formats. This is much preferable because otherwise it is impossible to get the string out of LibMseed.
Make sure that we test the path taken when a miniSEED id starts with "XFDSN:" or "FDSN:" but is empty otherwise.
df55731 to
b396060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
channel_code_parts's returned elements of a channel codeas
nothingif they were empty in a miniSEED code string, or if theformat was not as expected. However, the docstring actually stated they
would be 'empty', meaning empty strings. Update the behaviour to match
that documented.
At the same time, also stop erroring when encountering a channel code
which for any reason does not fit the expected formats. This is much
preferable because otherwise it is impossible to get the string out
of LibMseed.