Fix bug when splitting channel ids into separate codes when the network code is empty #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
anowacki
commented
May 5, 2022
- Fix Codecov badge in README
- channel_code_parts: Fix bug for empty network codes
The network code part of a miniSEED id can be empty, but the logic in `channel_code_parts` did not allow for this causing an error to be thrown erroneously. Fix this so that all parts of the id can be empty.
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
==========================================
- Coverage 87.05% 87.00% -0.05%
==========================================
Files 6 6
Lines 278 277 -1
==========================================
- Hits 242 241 -1
Misses 36 36
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.