Fix tests using time_tolerance on unsupported platforms
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `time_tolerance` option to `read_file` and `read_buffer` is not supported on PowerPC and ARM platforms, but we used the option unconditionally on all platforms in tests. Fix this to instead test for the correct throwing of an error on ARM and PowerPC and skip the `time_tolerance` tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
time_toleranceoption toread_fileandread_bufferis notsupported on PowerPC and ARM platforms, but we used the option
unconditionally on all platforms in tests. Fix this to instead test
for the correct throwing of an error on ARM and PowerPC and skip the
time_tolerancetests.