-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Get the default branch from env vars also allow to overwrite as parameter #230
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
I'm back lets merge this |
This broke our CI with:
Apparently, the |
@sbe-arg @sammcj
Edit: I commented here, as this is where the error message linked to, but I actually think it is #235 that broke things, as #235 introduced the exit 1. |
+1 to the above. This change broke our CI as well w/ the same error |
+1 . Broke the existing CI |
+1. Broke our CI pipenline with the error: "DEFAULT_BRANCH must not be null, something has gone wrong." |
+1 |
1 similar comment
+1 |
This project badly needs tests, especially if folks are going to run the action from main. @sbe-arg please revert |
If anyone here is/was affected by this breaking change, has development (or test automation) skills and is interested to helping to maintain this project - please let me or @sbe-arg know on the following issue - #238 This project isn't ours, we've just been added as contributors because it went unmaintained for some time. The project doesn't have reasonable test coverage (see #184), which is in part why we suggest people don't run it from main/master unless you're happy to be testing cutting edge changes. We're only two folks, in the same time zone so it's currently very much a best effort as we both work full time and have social lives etc... See #238 |
Hotfix