fix: ignore all other tag settings if custom_tag is set
#160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As outlined in the README, the `custom_tag` should override all other settings. Right now, if the `default_bump` is set to `none`, the `entrypoint.sh` script will exit before using the `custom_tag` This fixes the script to ignore all other tag settings when `custom_tag` is set.
|
happy to reintroduce and sort CUSTOM_TAG in #157 to avoid this. let me know for curiosity so we can document what are examples od custom_tag use cases |
|
reintroduced custom_tag in the pr #157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in the README, the
custom_tagshould override all othersettings. Right now, if the
default_bumpis set tonone, theentrypoint.shscript will exit before using thecustom_tagThis fixes the script to ignore all other tag settings when
custom_tagis set by adding an
ifblock to set$newto the custom tag when setand otherwise go through the other tag settings.
Fixes #159.